Hi Christoph,
I love your patch! Yet something to improve:
[auto build test ERROR on char-misc/char-misc-testing]
[also build test ERROR on powerpc/next linus/master v5.12-rc2 next-20210309]
[cannot apply to hnaz-linux-mm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Christoph-Hellwig/fs-rename-allo...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
080951f99de1e483a9a48f34c079b634f2912a54
config: riscv-randconfig-r034-20210309 (attached as .config)
compiler: clang version 13.0.0 (
https://github.com/llvm/llvm-project
820f508b08d7c94b2dd7847e9710d2bc36d3dd45)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
#
https://github.com/0day-ci/linux/commit/338f8e6b8568b85e6ab8a125ab242cac3...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Christoph-Hellwig/fs-rename-alloc_anon_inode-to-alloc_anon_inode_sb/20210310-005356
git checkout 338f8e6b8568b85e6ab8a125ab242cac37ed3ad8
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
> fs/libfs.c:1246:15: error: use of undeclared identifier
'alloc_anon_inode'; did you mean 'alloc_anon_inode_sb'?
EXPORT_SYMBOL(alloc_anon_inode);
^~~~~~~~~~~~~~~~
alloc_anon_inode_sb
include/linux/export.h:158:44: note: expanded from macro 'EXPORT_SYMBOL'
#define EXPORT_SYMBOL(sym) _EXPORT_SYMBOL(sym, "")
^
include/linux/export.h:155:50: note: expanded from macro '_EXPORT_SYMBOL'
#define _EXPORT_SYMBOL(sym, sec) __EXPORT_SYMBOL(sym, sec, "")
^
include/linux/export.h:147:56: note: expanded from macro '__EXPORT_SYMBOL'
#define __EXPORT_SYMBOL(sym, sec, ns) ___EXPORT_SYMBOL(sym, sec, ns)
^
include/linux/export.h:98:16: note: expanded from macro '___EXPORT_SYMBOL'
extern typeof(sym) sym; \
^
fs/libfs.c:1219:15: note: 'alloc_anon_inode_sb' declared here
struct inode *alloc_anon_inode_sb(struct super_block *s)
^
1 error generated.
vim +1246 fs/libfs.c
6987843ff7e836 Al Viro 2013-10-02 1218
338f8e6b8568b8 Christoph Hellwig 2021-03-09 1219 struct inode
*alloc_anon_inode_sb(struct super_block *s)
6987843ff7e836 Al Viro 2013-10-02 1220 {
6987843ff7e836 Al Viro 2013-10-02 1221 static const struct
address_space_operations anon_aops = {
6987843ff7e836 Al Viro 2013-10-02 1222 .set_page_dirty =
anon_set_page_dirty,
6987843ff7e836 Al Viro 2013-10-02 1223 };
6987843ff7e836 Al Viro 2013-10-02 1224 struct inode *inode =
new_inode_pseudo(s);
6987843ff7e836 Al Viro 2013-10-02 1225
6987843ff7e836 Al Viro 2013-10-02 1226 if (!inode)
6987843ff7e836 Al Viro 2013-10-02 1227 return ERR_PTR(-ENOMEM);
6987843ff7e836 Al Viro 2013-10-02 1228
6987843ff7e836 Al Viro 2013-10-02 1229 inode->i_ino = get_next_ino();
6987843ff7e836 Al Viro 2013-10-02 1230 inode->i_mapping->a_ops =
&anon_aops;
6987843ff7e836 Al Viro 2013-10-02 1231
6987843ff7e836 Al Viro 2013-10-02 1232 /*
6987843ff7e836 Al Viro 2013-10-02 1233 * Mark the inode dirty from the very
beginning,
6987843ff7e836 Al Viro 2013-10-02 1234 * that way it will never be moved to
the dirty
6987843ff7e836 Al Viro 2013-10-02 1235 * list because mark_inode_dirty()
will think
6987843ff7e836 Al Viro 2013-10-02 1236 * that it already _is_ on the dirty
list.
6987843ff7e836 Al Viro 2013-10-02 1237 */
6987843ff7e836 Al Viro 2013-10-02 1238 inode->i_state = I_DIRTY;
6987843ff7e836 Al Viro 2013-10-02 1239 inode->i_mode = S_IRUSR | S_IWUSR;
6987843ff7e836 Al Viro 2013-10-02 1240 inode->i_uid = current_fsuid();
6987843ff7e836 Al Viro 2013-10-02 1241 inode->i_gid = current_fsgid();
6987843ff7e836 Al Viro 2013-10-02 1242 inode->i_flags |= S_PRIVATE;
078cd8279e6599 Deepa Dinamani 2016-09-14 1243 inode->i_atime = inode->i_mtime
= inode->i_ctime = current_time(inode);
6987843ff7e836 Al Viro 2013-10-02 1244 return inode;
6987843ff7e836 Al Viro 2013-10-02 1245 }
6987843ff7e836 Al Viro 2013-10-02 @1246 EXPORT_SYMBOL(alloc_anon_inode);
1c994a0909a556 Jeff Layton 2014-08-27 1247
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org