Hi "Matthew,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on linux/master]
[also build test WARNING on linus/master hnaz-linux-mm/master v5.12-rc6 next-20210407]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Matthew-Wilcox-Oracle/Add-split_...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
5e46d1b78a03d52306f21f77a4e4a144b6d31486
config: x86_64-randconfig-a011-20210408 (attached as .config)
compiler: clang version 13.0.0 (
https://github.com/llvm/llvm-project
56ea2e2fdd691136d5e6631fa0e447173694b82c)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
#
https://github.com/0day-ci/linux/commit/31f96279760e4e4a2abf1d397e5c85fca...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Matthew-Wilcox-Oracle/Add-split_lock/20210408-132535
git checkout 31f96279760e4e4a2abf1d397e5c85fca955d908
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/infiniband/hw/hfi1/pcie.c:55:
In file included from drivers/infiniband/hw/hfi1/hfi.h:71:
include/linux/rhashtable.h:330:39: error: too few arguments to function call, expected
3, have 2
bit_spin_lock(0, (unsigned long *)bkt);
~~~~~~~~~~~~~ ^
include/linux/bit_spinlock.h:17:20: note: 'bit_spin_lock' declared here
static inline void bit_spin_lock(int bitnum, unsigned long *addr,
^
In file included from drivers/infiniband/hw/hfi1/pcie.c:55:
In file included from drivers/infiniband/hw/hfi1/hfi.h:71:
include/linux/rhashtable.h:339:42: error: too few arguments to function call, expected
3, have 2
bit_spin_lock(0, (unsigned long *)bucket);
~~~~~~~~~~~~~ ^
include/linux/bit_spinlock.h:17:20: note: 'bit_spin_lock' declared here
static inline void bit_spin_lock(int bitnum, unsigned long *addr,
^
In file included from drivers/infiniband/hw/hfi1/pcie.c:55:
In file included from drivers/infiniband/hw/hfi1/hfi.h:71:
include/linux/rhashtable.h:347:41: error: too few arguments to function call, expected
3, have 2
bit_spin_unlock(0, (unsigned long *)bkt);
~~~~~~~~~~~~~~~ ^
include/linux/bit_spinlock.h:50:20: note: 'bit_spin_unlock' declared here
static inline void bit_spin_unlock(int bitnum, unsigned long *addr,
^
> drivers/infiniband/hw/hfi1/pcie.c:95:31: warning: shift count
>= width of type [-Wshift-count-overflow]
ret = pci_set_dma_mask(pdev,
DMA_BIT_MASK(64));
^~~~~~~~~~~~~~~~
include/linux/dma-mapping.h:76:54: note: expanded from macro 'DMA_BIT_MASK'
#define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
^ ~~~
drivers/infiniband/hw/hfi1/pcie.c:109:43: warning: shift count >= width of type
[-Wshift-count-overflow]
ret = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
^~~~~~~~~~~~~~~~
include/linux/dma-mapping.h:76:54: note: expanded from macro 'DMA_BIT_MASK'
#define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
^ ~~~
2 warnings and 3 errors generated.
vim +95 drivers/infiniband/hw/hfi1/pcie.c
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 58
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 59 /*
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 60 * This
file contains PCIe utility routines.
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 61 */
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 62
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 63 /*
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 64 * Do
all the common PCIe setup and initialization.
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 65 */
57f97e96625fe8 drivers/infiniband/hw/hfi1/pcie.c Michael J. Ruhl 2018-08-15 66 int
hfi1_pcie_init(struct hfi1_devdata *dd)
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 67 {
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 68 int
ret;
57f97e96625fe8 drivers/infiniband/hw/hfi1/pcie.c Michael J. Ruhl 2018-08-15 69 struct
pci_dev *pdev = dd->pcidev;
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 70
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 71 ret =
pci_enable_device(pdev);
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 72 if
(ret) {
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 73 /*
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 74 *
This can happen (in theory) iff:
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 75 * We
did a chip reset, and then failed to reprogram the
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 76 *
BAR, or the chip reset due to an internal error. We then
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 77 *
unloaded the driver and reloaded it.
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 78 *
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 79 *
Both reset cases set the BAR back to initial state. For
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 80 *
the latter case, the AER sticky error bit at offset 0x718
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 81 *
should be set, but the Linux kernel doesn't yet know
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 82 *
about that, it appears. If the original BAR was retained
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 83 * in
the kernel data structures, this may be OK.
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 84 */
57f97e96625fe8 drivers/infiniband/hw/hfi1/pcie.c Michael J. Ruhl 2018-08-15 85
dd_dev_err(dd, "pci enable failed: error %d\n", -ret);
57f97e96625fe8 drivers/infiniband/hw/hfi1/pcie.c Michael J. Ruhl 2018-08-15 86
return ret;
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 87 }
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 88
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 89 ret =
pci_request_regions(pdev, DRIVER_NAME);
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 90 if
(ret) {
57f97e96625fe8 drivers/infiniband/hw/hfi1/pcie.c Michael J. Ruhl 2018-08-15 91
dd_dev_err(dd, "pci_request_regions fails: err %d\n", -ret);
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 92 goto
bail;
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 93 }
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 94
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 @95 ret =
pci_set_dma_mask(pdev, DMA_BIT_MASK(64));
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 96 if
(ret) {
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 97 /*
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 98 * If
the 64 bit setup fails, try 32 bit. Some systems
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 99 * do
not setup 64 bit maps on systems with 2GB or less
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 100 *
memory installed.
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 101 */
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 102 ret =
pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 103 if
(ret) {
57f97e96625fe8 drivers/infiniband/hw/hfi1/pcie.c Michael J. Ruhl 2018-08-15 104
dd_dev_err(dd, "Unable to set DMA mask: %d\n", ret);
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 105 goto
bail;
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 106 }
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 107 ret =
pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
e490974e675e8d drivers/staging/rdma/hfi1/pcie.c Jubin John 2016-02-14 108 } else
{
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 109 ret =
pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
e490974e675e8d drivers/staging/rdma/hfi1/pcie.c Jubin John 2016-02-14 110 }
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 111 if
(ret) {
57f97e96625fe8 drivers/infiniband/hw/hfi1/pcie.c Michael J. Ruhl 2018-08-15 112
dd_dev_err(dd, "Unable to set DMA consistent mask: %d\n", ret);
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 113 goto
bail;
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 114 }
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 115
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 116
pci_set_master(pdev);
0096765be01926 drivers/staging/rdma/hfi1/pcie.c Dean Luick 2016-02-03 117
(void)pci_enable_pcie_error_reporting(pdev);
57f97e96625fe8 drivers/infiniband/hw/hfi1/pcie.c Michael J. Ruhl 2018-08-15 118 return
0;
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 119
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 120 bail:
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 121
hfi1_pcie_cleanup(pdev);
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 122 return
ret;
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 123 }
7724105686e718 drivers/staging/rdma/hfi1/pcie.c Mike Marciniszyn 2015-07-30 124
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org