Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on next-20210413] [cannot apply to linux/master linus/master v5.12-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/i2c-mpc-Use-devm... base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next config: powerpc64-randconfig-r015-20210413 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 9829f5e6b1bca9b61efc629770d28bb9014dec45) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install powerpc64 cross compiling tool for clang build # apt-get install binutils-powerpc64-linux-gnu # https://github.com/0day-ci/linux/commit/31fed803b49f17742a0bfa9fb3940b5bc... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andy-Shevchenko/i2c-mpc-Use-devm_clk_get_optional/20210413-223941 git checkout 31fed803b49f17742a0bfa9fb3940b5bc487e4dd # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): .pm = MPC_I2C_PM_OPS, ^ 1 error generated. Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97 Depends on SOUND && !UML && SND && SND_SOC && SND_POWERPC_SOC && PPC_MPC52xx && PPC_BESTCOMM Selected by - SND_MPC52xx_SOC_EFIKA && SOUND && !UML && SND && SND_SOC && SND_POWERPC_SOC && PPC_EFIKA vim +/MPC_I2C_PM_OPS +824 drivers/i2c/busses/i2c-mpc.c 0d1cde235874b0 Jon Smirl 2008-06-30 816 8c86cb127b2b76 Kumar Gala 2005-07-27 817 /* Structure for a device driver */ 1c48a5c93da631 Grant Likely 2011-02-17 818 static struct platform_driver mpc_i2c_driver = { 8c86cb127b2b76 Kumar Gala 2005-07-27 819 .probe = fsl_i2c_probe, 0b255e927d47b5 Bill Pemberton 2012-11-27 820 .remove = fsl_i2c_remove, 3ae5eaec1d2d9c Russell King 2005-11-09 821 .driver = { 0d1cde235874b0 Jon Smirl 2008-06-30 822 .name = DRV_NAME, 4018294b53d1da Grant Likely 2010-04-13 823 .of_match_table = mpc_i2c_of_match, 0a488c49eac0ad Jingoo Han 2013-07-15 @824 .pm = MPC_I2C_PM_OPS, 3ae5eaec1d2d9c Russell King 2005-11-09 825 }, 8c86cb127b2b76 Kumar Gala 2005-07-27 826 }; 8c86cb127b2b76 Kumar Gala 2005-07-27 827 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org