[djwong-xfs:xfs-5.12-merge 25/36] fs/xfs/xfs_log.c:1062:9-10: WARNING: return of 0/1 in function 'xfs_log_need_covered' with return type bool
7:09 a.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git
xfs-5.12-merge
head: 560ab6c0d12ebccabb83638abe23a7875b946f9a
commit: 37444fc4cc398266fe0f71a9c0925620d44fb76a [25/36] xfs: lift writable fs check up
into log worker task
config: x86_64-randconfig-c002-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
"coccinelle warnings: (new ones prefixed by >>)"
> fs/xfs/xfs_log.c:1062:9-10: WARNING: return of 0/1 in function
'xfs_log_need_covered' with return type bool
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
7:09 a.m.
New subject: [PATCH] xfs: fix boolreturn.cocci warnings
From: kernel test robot <lkp(a)intel.com>
fs/xfs/xfs_log.c:1062:9-10: WARNING: return of 0/1 in function
'xfs_log_need_covered' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: 37444fc4cc39 ("xfs: lift writable fs check up into log worker task")
CC: Brian Foster <bfoster(a)redhat.com>
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git
xfs-5.12-merge
head: 560ab6c0d12ebccabb83638abe23a7875b946f9a
commit: 37444fc4cc398266fe0f71a9c0925620d44fb76a [25/36] xfs: lift writable fs check up
into log worker task
xfs_log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/xfs/xfs_log.c
+++ b/fs/xfs/xfs_log.c
@@ -1059,7 +1059,7 @@ xfs_log_need_covered(
bool needed = false;
if (!xlog_cil_empty(log))
- return 0;
+ return false;
spin_lock(&log->l_icloglock);
switch (log->l_covered_state) {
8:02 a.m.
New subject: [PATCH] xfs: fix boolreturn.cocci warnings
On Thu, Feb 11, 2021 at 04:09:16AM +0800, kernel test robot wrote:
From: kernel test robot <lkp(a)intel.com>
fs/xfs/xfs_log.c:1062:9-10: WARNING: return of 0/1 in function
'xfs_log_need_covered' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: 37444fc4cc39 ("xfs: lift writable fs check up into log worker task")
CC: Brian Foster <bfoster(a)redhat.com>
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
Reviewed-by: Brian Foster <bfoster(a)redhat.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git
xfs-5.12-merge
head: 560ab6c0d12ebccabb83638abe23a7875b946f9a
commit: 37444fc4cc398266fe0f71a9c0925620d44fb76a [25/36] xfs: lift writable fs check up
into log worker task
xfs_log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/xfs/xfs_log.c
+++ b/fs/xfs/xfs_log.c
@@ -1059,7 +1059,7 @@ xfs_log_need_covered(
bool needed = false;
if (!xlog_cil_empty(log))
- return 0;
+ return false;
spin_lock(&log->l_icloglock);
switch (log->l_covered_state) {
587
days inactive
587
days old
2 comments
2 participants
participants (2)
-
Brian Foster -
kernel test robot