Hi Thomas,
I love your patch! Yet something to improve:
[auto build test ERROR on next-20200914]
[also build test ERROR on v5.9-rc5]
[cannot apply to linuxtv-media/master drm-intel/for-linux-next tegra/for-next linus/master
v5.9-rc5 v5.9-rc4 v5.9-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/dma-buf-Flag-v...
base: f965d3ec86fa89285db0fbb983da76ba9c398efa
config: mips-randconfig-r013-20200914 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
> drivers/dma-buf/heaps/heap-helpers.c:269:10: error:
initialization of 'int (*)(struct dma_buf *, struct dma_buf_map *)' from
incompatible pointer type 'void * (*)(struct dma_buf *)'
[-Werror=incompatible-pointer-types]
269 | .vmap = dma_heap_dma_buf_vmap,
| ^~~~~~~~~~~~~~~~~~~~~
drivers/dma-buf/heaps/heap-helpers.c:269:10: note: (near initialization for
'heap_helper_ops.vmap')
cc1: some warnings being treated as errors
#
https://github.com/0day-ci/linux/commit/b9513704e28f25636f00827154183df60...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Thomas-Zimmermann/dma-buf-Flag-vmap-ed-memory-as-system-or-I-O-memory/20200914-192712
git checkout b9513704e28f25636f00827154183df60a80d95c
vim +269 drivers/dma-buf/heaps/heap-helpers.c
5248eb12fea890 John Stultz 2019-12-03 259
5248eb12fea890 John Stultz 2019-12-03 260 const struct dma_buf_ops heap_helper_ops = {
5248eb12fea890 John Stultz 2019-12-03 261 .map_dma_buf = dma_heap_map_dma_buf,
5248eb12fea890 John Stultz 2019-12-03 262 .unmap_dma_buf = dma_heap_unmap_dma_buf,
5248eb12fea890 John Stultz 2019-12-03 263 .mmap = dma_heap_mmap,
5248eb12fea890 John Stultz 2019-12-03 264 .release = dma_heap_dma_buf_release,
5248eb12fea890 John Stultz 2019-12-03 265 .attach = dma_heap_attach,
5248eb12fea890 John Stultz 2019-12-03 266 .detach = dma_heap_detach,
5248eb12fea890 John Stultz 2019-12-03 267 .begin_cpu_access =
dma_heap_dma_buf_begin_cpu_access,
5248eb12fea890 John Stultz 2019-12-03 268 .end_cpu_access =
dma_heap_dma_buf_end_cpu_access,
5248eb12fea890 John Stultz 2019-12-03 @269 .vmap = dma_heap_dma_buf_vmap,
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org