New subject: [PATCH 4/4] clk: bcm: Add BCM63268 timer clock and reset driver

Thursday, 4 March 2021

Hi "Álvaro,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on clk/clk-next]
[also build test ERROR on robh/for-next pza/reset/next v5.12-rc1 next-20210303]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:   
https://github.com/0day-ci/linux/commits/lvaro-Fern-ndez-Rojas/clk-add-BC...
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
        chmod +x ~/bin/make.cross
        #
https://github.com/0day-ci/linux/commit/f6057c7d442f720a3824acc27e306a673...
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review
lvaro-Fern-ndez-Rojas/clk-add-BCM63268-timer-clock-and-reset/20210226-034945
        git checkout f6057c7d442f720a3824acc27e306a67344348ce
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com&gt;

All errors (new ones prefixed by >>):

   drivers/clk/bcm/clk-bcm63268-timer.c: In function
'bcm63268_timer_reset_update':
...
> drivers/clk/bcm/clk-bcm63268-timer.c:91:8: error: implicit
declaration of function '__raw_readl'; did you mean '__raw_read_lock'?
[-Werror=implicit-function-declaration]       91 |  val =
__raw_readl(reset->regs);
         |        ^~~~~~~~~~~
         |        __raw_read_lock
...
> drivers/clk/bcm/clk-bcm63268-timer.c:96:2: error: implicit
declaration of function '__raw_writel'; did you mean '__raw_write_lock'?
[-Werror=implicit-function-declaration]       96 |  __raw_writel(val,
reset->regs);
         |  ^~~~~~~~~~~~
         |  __raw_write_lock
   cc1: some warnings being treated as errors

vim +91 drivers/clk/bcm/clk-bcm63268-timer.c

    82	
    83	static int bcm63268_timer_reset_update(struct reset_controller_dev *rcdev,
    84					unsigned long id, bool assert)
    85	{
    86		struct bcm63268_tclkrst_hw *reset = to_bcm63268_timer_reset(rcdev);
    87		unsigned long flags;
    88		uint32_t val;
    89	
    90		spin_lock_irqsave(&reset->lock, flags);
...
 91		val = __raw_readl(reset->regs);     92		if (assert)
    93			val &= ~BIT(id);
    94		else
    95			val |= BIT(id);
...
 96		__raw_writel(val, reset->regs);    
97		spin_unlock_irqrestore(&reset->lock, flags);
    98	
    99		return 0;
   100	}
   101	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

2022

2021

2020

2019

Re: [PATCH 4/4] clk: bcm: Add BCM63268 timer clock and reset driver