Hi Chris, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v5.5 next-20200130] [cannot apply to drm-tip/drm-tip] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-gem-Requir... base: git://anongit.freedesktop.org/drm-intel for-linux-next config: x86_64-defconfig (attached as .config) compiler: gcc-7 (Debian 7.5.0-3) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): drivers/gpu/drm/i915/gem/i915_gem_context.c: In function '__context_set_persistence': if (!intel_has_reset_engine(ctx->gt)) ^~ vim +569 drivers/gpu/drm/i915/gem/i915_gem_context.c 547 548 static int __context_set_persistence(struct i915_gem_context *ctx, bool state) 549 { 550 if (i915_gem_context_is_persistent(ctx) == state) 551 return 0; 552 553 if (state) { 554 /* 555 * Only contexts that are short-lived [that will expire or be 556 * reset] are allowed to survive past termination. We require 557 * hangcheck to ensure that the persistent requests are healthy. 558 */ 559 if (!i915_modparams.enable_hangcheck) 560 return -EINVAL; 561 562 i915_gem_context_set_persistence(ctx); 563 } else { 564 /* To cancel a context we use "preempt-to-idle" */ 565 if (!(ctx->i915->caps.scheduler & I915_SCHEDULER_CAP_PREEMPTION)) 566 return -ENODEV; 567 568 /* If the cancel fails, we then need to reset, cleanly! */ 570 return -ENODEV; 571 572 i915_gem_context_clear_persistence(ctx); 573 } 574 575 return 0; 576 } 577 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation