[sashal-linux-stable:queue-5.10 3/6] drivers/vdpa/vdpa_sim/vdpa_sim.c:45:4: sparse: sparse: symbol 'macaddr_buf' was not declared. Should it be
6:18 p.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
queue-5.10
head: a55e412193e86cc7e0913063bbfa3775db0aeec0
commit: 9eed430e3e700df359b0c6223789cae4c268f95c [3/6] vdpa_sim: store parsed MAC address
in a buffer
config: x86_64-randconfig-s022-20210219 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-229-g60c1f270-dirty
#
https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/c...
git remote add sashal-linux-stable
https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
git fetch --no-tags sashal-linux-stable queue-5.10
git checkout 9eed430e3e700df359b0c6223789cae4c268f95c
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
"sparse warnings: (new ones prefixed by >>)"
> drivers/vdpa/vdpa_sim/vdpa_sim.c:45:4: sparse: sparse: symbol
'macaddr_buf' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
6:18 p.m.
New subject: [RFC PATCH sashal-linux-stable] vdpa_sim: macaddr_buf[] can be static
Fixes: 9eed430e3e70 ("vdpa_sim: store parsed MAC address in a buffer")
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
vdpa_sim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
index bc27fa485c3e8..690f4deb56432 100644
--- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
+++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
@@ -42,7 +42,7 @@ static char *macaddr;
module_param(macaddr, charp, 0);
MODULE_PARM_DESC(macaddr, "Ethernet MAC address");
-u8 macaddr_buf[ETH_ALEN];
+static u8 macaddr_buf[ETH_ALEN];
struct vdpasim_virtqueue {
struct vringh vring;
578
days inactive
578
days old
1 comments
1 participants
participants (1)
-
kernel test robot