Hi Gal, I love your patch! Yet something to improve: [auto build test ERROR on 5f0b2a6093a4d9aab093964c65083fe801ef1e58] url: https://github.com/0day-ci/linux/commits/Gal-Pressman/Add-support-for-0xe... base: 5f0b2a6093a4d9aab093964c65083fe801ef1e58 config: x86_64-allyesconfig (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project cf1105069648446d58adfb7a6cc590013d6886ba) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All error/warnings (new ones prefixed by >>): DEFINE_COMP_HANDSHAKE(max_tx_batch, EFA_ALLOC_UCONTEXT_CMD_COMP_TX_BATCH), ^ drivers/infiniband/hw/efa/efa_verbs.c:1520:4: note: expanded from macro 'DEFINE_COMP_HANDSHAKE' DEFINE_GET_DEV_ATTR_FUNC(_attr) \ ^ drivers/infiniband/hw/efa/efa_verbs.c:1506:2: note: expanded from macro 'DEFINE_GET_DEV_ATTR_FUNC' { \ ^ drivers/infiniband/hw/efa/efa_verbs.c:1521:4: note: expanded from macro 'DEFINE_COMP_HANDSHAKE' DEFINE_CHECK_COMP_FUNC(_attr, _mask) \ ^ drivers/infiniband/hw/efa/efa_verbs.c:1512:2: note: expanded from macro 'DEFINE_CHECK_COMP_FUNC' { \ ^ drivers/infiniband/hw/efa/efa_verbs.c:1522:4: note: expanded from macro 'DEFINE_COMP_HANDSHAKE' check_comp_##_attr; \ ^ <scratch space>:191:1: note: expanded from here check_comp_max_tx_batch ^ drivers/infiniband/hw/efa/efa_verbs.c:1534:3: error: function definition is not allowed here DEFINE_COMP_HANDSHAKE(min_sq_depth, EFA_ALLOC_UCONTEXT_CMD_COMP_MIN_SQ_WR), ^ drivers/infiniband/hw/efa/efa_verbs.c:1520:4: note: expanded from macro 'DEFINE_COMP_HANDSHAKE' DEFINE_GET_DEV_ATTR_FUNC(_attr) \ ^ drivers/infiniband/hw/efa/efa_verbs.c:1506:2: note: expanded from macro 'DEFINE_GET_DEV_ATTR_FUNC' { \ ^ drivers/infiniband/hw/efa/efa_verbs.c:1534:3: error: function definition is not allowed here drivers/infiniband/hw/efa/efa_verbs.c:1521:4: note: expanded from macro 'DEFINE_COMP_HANDSHAKE' DEFINE_CHECK_COMP_FUNC(_attr, _mask) \ ^ drivers/infiniband/hw/efa/efa_verbs.c:1512:2: note: expanded from macro 'DEFINE_CHECK_COMP_FUNC' { \ ^ drivers/infiniband/hw/efa/efa_verbs.c:1522:4: note: expanded from macro 'DEFINE_COMP_HANDSHAKE' check_comp_##_attr; \ ^ <scratch space>:196:1: note: expanded from here check_comp_min_sq_depth ^ DEFINE_COMP_HANDSHAKE(max_tx_batch, EFA_ALLOC_UCONTEXT_CMD_COMP_TX_BATCH), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/infiniband/hw/efa/efa_verbs.c:1519:17: note: expanded from macro 'DEFINE_COMP_HANDSHAKE' .check_comp = ({ \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/infiniband/hw/efa/efa_verbs.c:1534:3: error: initializing 'bool (*)(const struct efa_dev *, u32)' (aka '_Bool (*)(const struct efa_dev *, unsigned int)') with an expression of incompatible type 'void' DEFINE_COMP_HANDSHAKE(min_sq_depth, EFA_ALLOC_UCONTEXT_CMD_COMP_MIN_SQ_WR), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/infiniband/hw/efa/efa_verbs.c:1519:17: note: expanded from macro 'DEFINE_COMP_HANDSHAKE' .check_comp = ({ \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ for (i = 0; i < ARRAY_SIZE(user_comp_handshakes); i++) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:47:32: note: expanded from macro 'ARRAY_SIZE' #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) ^~~~~ int efa_user_comp_handshake(const struct ib_ucontext *ibucontext, ^ drivers/infiniband/hw/efa/efa_verbs.c:1526:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int efa_user_comp_handshake(const struct ib_ucontext *ibucontext, ^ static 1 warning and 9 errors generated. vim +1533 drivers/infiniband/hw/efa/efa_verbs.c 1503 1504 #define DEFINE_GET_DEV_ATTR_FUNC(_attr) \ 1505 bool dev_attr_##_attr(const struct efa_dev *dev) \ 1506 { \ 1507 return dev->dev_attr._attr; \ 1508 } 1509 1510 #define DEFINE_CHECK_COMP_FUNC(_attr, _mask) \ 1511 bool check_comp_##_attr(const struct efa_dev *dev, u32 comp_mask) \ 1512 { \ 1513 return !dev_attr_##_attr(dev) || (comp_mask & (_mask)); \ 1514 } 1515 1516 #define DEFINE_COMP_HANDSHAKE(_attr, _mask) \ 1517 { \ 1518 .attr = #_attr, \ 1519 .check_comp = ({ \ 1520 DEFINE_GET_DEV_ATTR_FUNC(_attr) \ 1521 DEFINE_CHECK_COMP_FUNC(_attr, _mask) \ 1522 check_comp_##_attr; \ 1523 }), \ 1524 } 1525 1527 const struct efa_ibv_alloc_ucontext_cmd *cmd) 1528 { 1529 struct { 1530 char *attr; 1531 bool (*check_comp)(const struct efa_dev *dev, u32 comp_mask); 1532 } user_comp_handshakes[] = { 1535 }; 1536 struct efa_dev *dev = to_edev(ibucontext->device); 1537 int i; 1538 1540 if (!user_comp_handshakes[i].check_comp(dev, cmd->comp_mask)) { 1541 ibdev_dbg(&dev->ibdev, 1542 "Userspace handshake failed for %s attribute\n", 1543 user_comp_handshakes[i].attr); 1544 return -EOPNOTSUPP; 1545 } 1546 } 1547 1548 return 0; 1549 } 1550 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org