[kdave-btrfs-devel:misc-next 100/109] fs/btrfs/sysfs.c:1355:5: sparse: sparse: symbol 'btrfs_sysfs_add_fs_devices' was not declared. Should it be
10:38 p.m.
tree: https://github.com/kdave/btrfs-devel.git misc-next
head: a99530d13cc95eec4869544f8000bbf7755d671b
commit: fd8e11fb8ffcb957a87dd0897b2e8c8535167391 [100/109] btrfs: simplify parameters of
btrfs_sysfs_add_devices_dir
config: i386-randconfig-s002-20200909 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-191-g10164920-dirty
git checkout fd8e11fb8ffcb957a87dd0897b2e8c8535167391
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
> fs/btrfs/sysfs.c:1355:5: sparse: sparse: symbol
'btrfs_sysfs_add_fs_devices' was not declared. Should it be static?
fs/btrfs/sysfs.c:534:9: sparse: sparse: context imbalance in 'btrfs_show_u64' -
different lock contexts for basic block
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
10:38 p.m.
New subject: [RFC PATCH kdave-btrfs-devel] btrfs: btrfs_sysfs_add_fs_devices() can be static
Fixes: fd8e11fb8ffc ("btrfs: simplify parameters of
btrfs_sysfs_add_devices_dir")
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
index 1f14b08cc04f5..bc341560dc69c 100644
--- a/fs/btrfs/sysfs.c
+++ b/fs/btrfs/sysfs.c
@@ -1352,7 +1352,7 @@ int btrfs_sysfs_add_device(struct btrfs_device *device)
return ret;
}
-int btrfs_sysfs_add_fs_devices(struct btrfs_fs_devices *fs_devices)
+static int btrfs_sysfs_add_fs_devices(struct btrfs_fs_devices *fs_devices)
{
int ret;
struct btrfs_device *device;
740
days inactive
740
days old
1 comments
1 participants
participants (1)
-
kernel test robot