Hi Greg,
I just fixed compile warning but fail to push to remote REPO:
fatal: unable to access
'https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/': The requested
URL returned error: 403
So I attach patch for you review.
Sincerely,
Jason
-----Original Message-----
From: kernel test robot <lkp(a)intel.com>
Sent: Friday, June 18, 2021 11:27 PM
To: Jason Li <jason.li(a)cortina-access.com>
Cc: kbuild-all(a)lists.01.org; linux-serial(a)vger.kernel.org; Greg Kroah-Hartman
<gregkh(a)linuxfoundation.org>
Subject: [tty:tty-testing 218/218] drivers/tty/serial/serial_cortina-access.c:469:6:
warning: no previous prototype for 'cortina_console_write'
tree:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
head: b61c8bf4694b5115766849378dcb8787ff54e65e
commit: b61c8bf4694b5115766849378dcb8787ff54e65e [218/218] tty: serial: Add UART driver
for Cortina-Access platform
config: m68k-allyesconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/commit/?id...
git remote add tty
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
git fetch --no-tags tty tty-testing
git checkout b61c8bf4694b5115766849378dcb8787ff54e65e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/tty/serial/serial_cortina-access.c:76:27: warning: no previous prototype for
'cortina_uart_get_port' [-Wmissing-prototypes]
76 | struct cortina_uart_port *cortina_uart_get_port(unsigned int index)
| ^~~~~~~~~~~~~~~~~~~~~
> drivers/tty/serial/serial_cortina-access.c:469:6: warning: no
> previous prototype for 'cortina_console_write' [-Wmissing-prototypes]
469 | void cortina_console_write(struct console *co, const char *s,
| ^~~~~~~~~~~~~~~~~~~~~
vim +/cortina_console_write +469 drivers/tty/serial/serial_cortina-access.c
467
468 #ifdef CONFIG_SERIAL_CORTINA_ACCESS_CONSOLE
469 void cortina_console_write(struct console *co, const char *s,
470 unsigned int count)
471 {
472 struct uart_port *port;
473 struct cortina_uart_port *pca_port;
474 unsigned int i, previous;
475 unsigned long flags;
476 int locked;
477
478 pca_port = cortina_uart_get_port(co->index);
479 port = &pca_port->uart;
480
481 local_irq_save(flags);
482 if (port->sysrq) {
483 locked = 0;
484 } else if (oops_in_progress) {
485 locked = spin_trylock(&port->lock);
486 } else {
487 spin_lock(&port->lock);
488 locked = 1;
489 }
490
491 /* Save current state */
492 previous = readl(port->membase + IE);
493 /* Disable Tx interrupts so this all goes out in one go */
494 cortina_uart_stop_tx(port);
495
496 /* Write all the chars */
497 for (i = 0; i < count; i++) {
498 /* Wait the TX buffer to be empty, which can't take forever */
499 while (!(readl(port->membase + INFO) & INFO_TX_EMPTY))
500 cpu_relax();
501
502 /* Send the char */
503 writel(*s, port->membase + TX_DAT);
504
505 /* CR/LF stuff */
506 if (*s++ == '\n') {
507 /* Wait the TX buffer to be empty */
508 while (!(readl(port->membase + INFO) & INFO_TX_EMPTY))
509 cpu_relax();
510 writel('\r', port->membase + TX_DAT);
511 }
512 }
513
514 writel(previous, port->membase + IE); /* Put it all back */
515
516 if (locked)
517 spin_unlock(&port->lock);
518 local_irq_restore(flags);
519 }
520
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org