Hi Brendan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on a2f0b878c3ca531a1706cb2a8b079cea3b17bafc] url: https://github.com/0day-ci/linux/commits/Brendan-Higgins/kunit-create-a-c... base: a2f0b878c3ca531a1706cb2a8b079cea3b17bafc config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 7.5.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.5.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): In file included from fs/ext4/inode-test.c:7:0: fs/ext4/inode-test.c: In function 'kunit_test_suites_init': include/kunit/test.h:211:34: error: invalid initializer struct kunit_suite *suites[] = (__suites); \ ^ include/kunit/test.h:231:2: note: in expansion of macro 'kunit_test_suites_for_module' kunit_test_suites_for_module(unique_array); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/kunit/test.h:254:2: note: in expansion of macro '__kunit_test_suites' __kunit_test_suites(__UNIQUE_ID(array), \ ^~~~~~~~~~~~~~~~~~~ kunit_test_suites(&ext4_inode_test_suite); ^~~~~~~~~~~~~~~~~ vim +/kunit_test_suites +272 fs/ext4/inode-test.c 1cbeab1b242d16 Iurii Zaikin 2019-10-17 271 c475c77d5b5639 Alan Maguire 2020-01-06 @272 kunit_test_suites(&ext4_inode_test_suite); c475c77d5b5639 Alan Maguire 2020-01-06 273 :::::: The code at line 272 was first introduced by commit :::::: c475c77d5b56398303e726969e81208196b3aab3 kunit: allow kunit tests to be loaded as a module :::::: TO: Alan Maguire <alan.maguire(a)oracle.com&gt; :::::: CC: Shuah Khan <skhan(a)linuxfoundation.org&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org