Hi Robert,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next v5.16 next-20220121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Robert-Beckett/discrete-card-64K...
base:
git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: i386-randconfig-a005-20220117
(
https://download.01.org/0day-ci/archive/20220121/202201211905.O4FxXbsX-lk...)
compiler: clang version 14.0.0 (
https://github.com/llvm/llvm-project
d4baf3b1322b84816aa623d8e8cb45a49cb68b84)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/e7a6d547c26b78357dbad93dc9d8df90b...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Robert-Beckett/discrete-card-64K-page-support/20220121-044244
git checkout e7a6d547c26b78357dbad93dc9d8df90bc51d025
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir
ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/i915/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/i915/i915_gem_gtt.c:296:
> drivers/gpu/drm/i915/selftests/i915_gem_gtt.c:1146:49: error:
implicit conversion from enumeration type 'enum intel_region_id' to different
enumeration type 'enum intel_memory_type' [-Werror,-Wenum-conversion]
u64 min_alignment = i915_vm_min_alignment(vm, id);
~~~~~~~~~~~~~~~~~~~~~ ^~
1 error generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SND_SOC_CS35L41_SPI
Depends on SOUND && !UML && SND && SND_SOC &&
SPI_MASTER
Selected by
- SND_SOC_AMD_VANGOGH_MACH && SOUND && !UML && SND &&
SND_SOC && SND_SOC_AMD_ACP5x && I2C
vim +1146 drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
1131
1132 static int misaligned_pin(struct i915_address_space *vm,
1133 u64 hole_start, u64 hole_end,
1134 unsigned long end_time)
1135 {
1136 struct intel_memory_region *mr;
1137 enum intel_region_id id;
1138 unsigned long flags = PIN_OFFSET_FIXED | PIN_USER;
1139 int err = 0;
1140 u64 hole_size = hole_end - hole_start;
1141
1142 if (i915_is_ggtt(vm))
1143 flags |= PIN_GLOBAL;
1144
1145 for_each_memory_region(mr, vm->i915, id) {
1146 u64 min_alignment = i915_vm_min_alignment(vm, id);
1147 u64 size = min_alignment;
1148 u64 addr = round_up(hole_start + (hole_size / 2), min_alignment);
1149
1150 /* we can't test < 4k alignment due to flags being encoded in lower bits
*/
1151 if (min_alignment != I915_GTT_PAGE_SIZE_4K) {
1152 err = misaligned_case(vm, mr, addr + (min_alignment / 2), size, flags);
1153 /* misaligned should error with -EINVAL*/
1154 if (!err)
1155 err = -EBADSLT;
1156 if (err != -EINVAL)
1157 return err;
1158 }
1159
1160 /* test for vma->size expansion to min page size */
1161 err = misaligned_case(vm, mr, addr, PAGE_SIZE, flags);
1162 if (min_alignment > hole_size) {
1163 if (!err)
1164 err = -EBADSLT;
1165 else if (err == -ENOSPC)
1166 err = 0;
1167 }
1168 if (err)
1169 return err;
1170
1171 /* test for intermediate size not expanding vma->size for large alignments */
1172 err = misaligned_case(vm, mr, addr, size / 2, flags);
1173 if (min_alignment > hole_size) {
1174 if (!err)
1175 err = -EBADSLT;
1176 else if (err == -ENOSPC)
1177 err = 0;
1178 }
1179 if (err)
1180 return err;
1181 }
1182
1183 return 0;
1184 }
1185
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org