Hi Manasi, I love your patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [also build test ERROR on next-20200430] [cannot apply to drm-intel/for-linux-next linus/master v5.7-rc3] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Manasi-Navare/Rebased-Big-Joiner... base: git://anongit.freedesktop.org/drm/drm-tip drm-tip config: x86_64-defconfig (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): drivers/gpu/drm/i915/display/intel_display.c: In function 'skl_update_scaler_crtc': const struct drm_display_mode *pipe_mode = &state->hw.pipe_mode; ^~~~~ statx drivers/gpu/drm/i915/display/intel_display.c:6094:46: note: each undeclared identifier is reported only once for each function it appears in vim +6094 drivers/gpu/drm/i915/display/intel_display.c 6091 6092 static int skl_update_scaler_crtc(struct intel_crtc_state *crtc_state) 6093 { 6095 int width, height; 6096 6097 if (crtc_state->pch_pfit.enabled) { 6098 width = drm_rect_width(&crtc_state->pch_pfit.dst); 6099 height = drm_rect_height(&crtc_state->pch_pfit.dst); 6100 } else { 6101 width = pipe_mode->crtc_hdisplay; 6102 height = pipe_mode->crtc_vdisplay; 6103 } 6104 return skl_update_scaler(crtc_state, !crtc_state->hw.active, 6105 SKL_CRTC_INDEX, 6106 &crtc_state->scaler_state.scaler_id, 6107 crtc_state->pipe_src_w, crtc_state->pipe_src_h, 6108 width, height, NULL, 0, 6109 crtc_state->pch_pfit.enabled); 6110 } 6111 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org