Hi Moudy,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on robh/for-next mediatek/for-next v5.14-rc2 next-20210719]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Moudy-Ho/media-mediatek-support-...
base:
git://linuxtv.org/media_tree.git master
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/ca5b8c1fac55efa08e8362a4aa345c474...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Moudy-Ho/media-mediatek-support-mdp3-on-mt8183-platform/20210719-154845
git checkout ca5b8c1fac55efa08e8362a4aa345c474b798326
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c: In function
'mdp_sub_comps_create':
> drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:1232:29: warning:
implicit conversion from 'enum mdp_comp_id' to 'enum mdp_comp_type'
[-Wenum-conversion]
1232 | enum mdp_comp_type type = MDP_COMP_NONE;
| ^~~~~~~~~~~~~
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c: In function 'mdp_mm_init':
drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c:1282:6: warning: unused variable
'ret' [-Wunused-variable]
1282 | int ret;
| ^~~
vim +1232 drivers/media/platform/mtk-mdp3/mtk-mdp3-comp.c
1222
1223 static int mdp_sub_comps_create(struct mdp_dev *mdp, struct device_node *node)
1224 {
1225 struct device *dev = &mdp->pdev->dev;
1226 struct property *prop;
1227 const char *name;
1228 int index = 0;
1229
1230 of_property_for_each_string(node, "mdp3-comps", prop, name) {
1231 const struct of_device_id *matches = mdp_sub_comp_dt_ids;
1232 enum mdp_comp_type type = MDP_COMP_NONE;
1233 u32
alias_id;
1234 int id, ret;
1235 struct mdp_comp *comp;
1236
1237 for (; matches->compatible[0]; matches++) {
1238 if (of_compat_cmp(name, matches->compatible,
1239 strlen(matches->compatible)) == 0) {
1240 type = (enum mdp_comp_type)matches->data;
1241 break;
1242 }
1243 }
1244
1245 ret = of_property_read_u32_index(node, "mdp3-comp-ids",
1246 index, &alias_id);
1247 if (ret) {
1248 dev_warn(dev, "Skipping unknown component %s\n", name);
1249 return ret;
1250 }
1251
1252 id = mdp_comp_get_id(type, alias_id);
1253 if (id < 0) {
1254 dev_err(dev, "Failed to get component id: "
1255 "%s type %d, alias %d\n", name, type, alias_id);
1256 return -ENODEV;
1257 }
1258
1259 comp = mdp_comp_create(mdp, node, id);
1260 if (IS_ERR(comp))
1261 return PTR_ERR(comp);
1262
1263 index++;
1264 }
1265 return 0;
1266 }
1267
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org