[joro:sev-es-client-tip 29/76] arch/x86/kernel/head64.c:67:20: sparse: sparse: symbol 'startup_gdt' was not declared. Should it be
12:07 p.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/joro/linux.git sev-es-client-tip
head: 57349dbe54433697c5b96bd5d8b5bd7499754d2b
commit: c12cc81e6b52de5e4c779e29d7ec903eff341cbc [29/76] x86/head/64: Install startup GDT
config: x86_64-randconfig-s022-20200717 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-49-g707c5017-dirty
git checkout c12cc81e6b52de5e4c779e29d7ec903eff341cbc
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
> arch/x86/kernel/head64.c:67:20: sparse: sparse: symbol
'startup_gdt' was not declared. Should it be static?
> arch/x86/kernel/head64.c:77:17: sparse: sparse: symbol 'startup_gdt_descr'
was not declared. Should it be static?
arch/x86/kernel/head64.c:68:43: sparse:
sparse: cast truncates bits from constant value (fffff becomes ffff)
arch/x86/kernel/head64.c:69:43: sparse: sparse: cast truncates bits from constant value
(fffff becomes ffff)
arch/x86/kernel/head64.c:70:43: sparse: sparse: cast truncates bits from constant value
(fffff becomes ffff)
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
12:07 p.m.
New subject: [RFC PATCH joro] x86/head/64: startup_gdt[] can be static
Fixes: c12cc81e6b52 ("x86/head/64: Install startup GDT")
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
head64.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c
index 74766728baf32..0f12adcc3bf83 100644
--- a/arch/x86/kernel/head64.c
+++ b/arch/x86/kernel/head64.c
@@ -64,7 +64,7 @@ EXPORT_SYMBOL(vmemmap_base);
/*
* GDT used on the boot CPU before switching to virtual addresses.
*/
-struct desc_struct startup_gdt[GDT_ENTRIES] = {
+static struct desc_struct startup_gdt[GDT_ENTRIES] = {
[GDT_ENTRY_KERNEL32_CS] = GDT_ENTRY_INIT(0xc09b, 0, 0xfffff),
[GDT_ENTRY_KERNEL_CS] = GDT_ENTRY_INIT(0xa09b, 0, 0xfffff),
[GDT_ENTRY_KERNEL_DS] = GDT_ENTRY_INIT(0xc093, 0, 0xfffff),
@@ -74,7 +74,7 @@ struct desc_struct startup_gdt[GDT_ENTRIES] = {
* Address needs to be set at runtime because it references the startup_gdt while
* the kernel still uses a direct mapping.
*/
-struct desc_ptr startup_gdt_descr = {
+static struct desc_ptr startup_gdt_descr = {
.size = sizeof(startup_gdt),
.address = 0,
};
794
days inactive
794
days old
1 comments
1 participants
participants (1)
-
kernel test robot