Hi Dafna, I love your patch! Perhaps something to improve: [auto build test WARNING on media-tree/master] [also build test WARNING on linux/master linus/master v5.16-rc1 next-20211118] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Dafna-Hirschfeld/media-mtk-vcode... base: git://linuxtv.org/media_tree.git master config: arm-buildonly-randconfig-r003-20211118 (attached as .config) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/0day-ci/linux/commit/87678e46cdd12f69edad572f8561e8ee9... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Dafna-Hirschfeld/media-mtk-vcodec-few-fixes/20211117-210840 git checkout 87678e46cdd12f69edad572f8561e8ee929d1d16 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): sizeof(struct mtk_h264_sps_param), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h:46:46: note: expanded from macro 'mtk_vcodec_debug' ((struct mtk_vcodec_ctx *)(h)->ctx)->id, ##args) ^~~~ include/linux/printk.h:570:26: note: expanded from macro 'pr_debug' dynamic_pr_debug(fmt, ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ include/linux/dynamic_debug.h:163:22: note: expanded from macro 'dynamic_pr_debug' pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ include/linux/dynamic_debug.h:152:56: note: expanded from macro '_dynamic_func_call' __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__) ^~~~~~~~~~~ include/linux/dynamic_debug.h:134:15: note: expanded from macro '__dynamic_func_call' func(&id, ##__VA_ARGS__); \ ^~~~~~~~~~~ drivers/media/platform/mtk-vcodec/vdec/vdec_h264_req_if.c:642:5: warning: format specifies type 'unsigned long' but the argument has type 'unsigned int' [-Wformat] sizeof(struct mtk_h264_pps_param), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h:46:46: note: expanded from macro 'mtk_vcodec_debug' ((struct mtk_vcodec_ctx *)(h)->ctx)->id, ##args) ^~~~ include/linux/printk.h:570:26: note: expanded from macro 'pr_debug' dynamic_pr_debug(fmt, ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ include/linux/dynamic_debug.h:163:22: note: expanded from macro 'dynamic_pr_debug' pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ include/linux/dynamic_debug.h:152:56: note: expanded from macro '_dynamic_func_call' __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__) ^~~~~~~~~~~ include/linux/dynamic_debug.h:134:15: note: expanded from macro '__dynamic_func_call' func(&id, ##__VA_ARGS__); \ ^~~~~~~~~~~ drivers/media/platform/mtk-vcodec/vdec/vdec_h264_req_if.c:643:5: warning: format specifies type 'unsigned long' but the argument has type 'unsigned int' [-Wformat] sizeof(struct mtk_h264_dec_slice_param), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h:46:46: note: expanded from macro 'mtk_vcodec_debug' ((struct mtk_vcodec_ctx *)(h)->ctx)->id, ##args) ^~~~ include/linux/printk.h:570:26: note: expanded from macro 'pr_debug' dynamic_pr_debug(fmt, ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ include/linux/dynamic_debug.h:163:22: note: expanded from macro 'dynamic_pr_debug' pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ include/linux/dynamic_debug.h:152:56: note: expanded from macro '_dynamic_func_call' __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__) ^~~~~~~~~~~ include/linux/dynamic_debug.h:134:15: note: expanded from macro '__dynamic_func_call' func(&id, ##__VA_ARGS__); \ ^~~~~~~~~~~ drivers/media/platform/mtk-vcodec/vdec/vdec_h264_req_if.c:644:5: warning: format specifies type 'unsigned long' but the argument has type 'unsigned int' [-Wformat] sizeof(struct mtk_h264_dpb_info)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h:46:46: note: expanded from macro 'mtk_vcodec_debug' ((struct mtk_vcodec_ctx *)(h)->ctx)->id, ##args) ^~~~ include/linux/printk.h:570:26: note: expanded from macro 'pr_debug' dynamic_pr_debug(fmt, ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ include/linux/dynamic_debug.h:163:22: note: expanded from macro 'dynamic_pr_debug' pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ include/linux/dynamic_debug.h:152:56: note: expanded from macro '_dynamic_func_call' __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__) ^~~~~~~~~~~ include/linux/dynamic_debug.h:134:15: note: expanded from macro '__dynamic_func_call' func(&id, ##__VA_ARGS__); \ ^~~~~~~~~~~ 4 warnings generated. vim +641 drivers/media/platform/mtk-vcodec/vdec/vdec_h264_req_if.c 06fa5f757dc5a5 Yunfei Dong 2021-08-06 611 06fa5f757dc5a5 Yunfei Dong 2021-08-06 612 static int vdec_h264_slice_init(struct mtk_vcodec_ctx *ctx) 06fa5f757dc5a5 Yunfei Dong 2021-08-06 613 { 06fa5f757dc5a5 Yunfei Dong 2021-08-06 614 struct vdec_h264_slice_inst *inst; 06fa5f757dc5a5 Yunfei Dong 2021-08-06 615 int err; 06fa5f757dc5a5 Yunfei Dong 2021-08-06 616 06fa5f757dc5a5 Yunfei Dong 2021-08-06 617 inst = kzalloc(sizeof(*inst), GFP_KERNEL); 06fa5f757dc5a5 Yunfei Dong 2021-08-06 618 if (!inst) 06fa5f757dc5a5 Yunfei Dong 2021-08-06 619 return -ENOMEM; 06fa5f757dc5a5 Yunfei Dong 2021-08-06 620 06fa5f757dc5a5 Yunfei Dong 2021-08-06 621 inst->ctx = ctx; 06fa5f757dc5a5 Yunfei Dong 2021-08-06 622 06fa5f757dc5a5 Yunfei Dong 2021-08-06 623 inst->vpu.id = SCP_IPI_VDEC_H264; 06fa5f757dc5a5 Yunfei Dong 2021-08-06 624 inst->vpu.ctx = ctx; 06fa5f757dc5a5 Yunfei Dong 2021-08-06 625 06fa5f757dc5a5 Yunfei Dong 2021-08-06 626 err = vpu_dec_init(&inst->vpu); 06fa5f757dc5a5 Yunfei Dong 2021-08-06 627 if (err) { 06fa5f757dc5a5 Yunfei Dong 2021-08-06 628 mtk_vcodec_err(inst, "vdec_h264 init err=%d", err); 06fa5f757dc5a5 Yunfei Dong 2021-08-06 629 goto error_free_inst; 06fa5f757dc5a5 Yunfei Dong 2021-08-06 630 } 06fa5f757dc5a5 Yunfei Dong 2021-08-06 631 06fa5f757dc5a5 Yunfei Dong 2021-08-06 632 memcpy(&inst->vsi_ctx, inst->vpu.vsi, sizeof(inst->vsi_ctx)); 06fa5f757dc5a5 Yunfei Dong 2021-08-06 633 inst->vsi_ctx.dec.resolution_changed = true; 06fa5f757dc5a5 Yunfei Dong 2021-08-06 634 inst->vsi_ctx.dec.realloc_mv_buf = true; 06fa5f757dc5a5 Yunfei Dong 2021-08-06 635 06fa5f757dc5a5 Yunfei Dong 2021-08-06 636 err = allocate_predication_buf(inst); 06fa5f757dc5a5 Yunfei Dong 2021-08-06 637 if (err) 06fa5f757dc5a5 Yunfei Dong 2021-08-06 638 goto error_deinit; 06fa5f757dc5a5 Yunfei Dong 2021-08-06 639 87678e46cdd12f Dafna Hirschfeld 2021-11-17 640 mtk_vcodec_debug(inst, "struct size = %lu,%lu,%lu,%lu\n", 06fa5f757dc5a5 Yunfei Dong 2021-08-06 @641 sizeof(struct mtk_h264_sps_param), 06fa5f757dc5a5 Yunfei Dong 2021-08-06 642 sizeof(struct mtk_h264_pps_param), 06fa5f757dc5a5 Yunfei Dong 2021-08-06 643 sizeof(struct mtk_h264_dec_slice_param), 06fa5f757dc5a5 Yunfei Dong 2021-08-06 644 sizeof(struct mtk_h264_dpb_info)); 06fa5f757dc5a5 Yunfei Dong 2021-08-06 645 06fa5f757dc5a5 Yunfei Dong 2021-08-06 646 mtk_vcodec_debug(inst, "H264 Instance >> %p", inst); 06fa5f757dc5a5 Yunfei Dong 2021-08-06 647 06fa5f757dc5a5 Yunfei Dong 2021-08-06 648 ctx->drv_handle = inst; 06fa5f757dc5a5 Yunfei Dong 2021-08-06 649 return 0; 06fa5f757dc5a5 Yunfei Dong 2021-08-06 650 06fa5f757dc5a5 Yunfei Dong 2021-08-06 651 error_deinit: 06fa5f757dc5a5 Yunfei Dong 2021-08-06 652 vpu_dec_deinit(&inst->vpu); 06fa5f757dc5a5 Yunfei Dong 2021-08-06 653 06fa5f757dc5a5 Yunfei Dong 2021-08-06 654 error_free_inst: 06fa5f757dc5a5 Yunfei Dong 2021-08-06 655 kfree(inst); 06fa5f757dc5a5 Yunfei Dong 2021-08-06 656 return err; 06fa5f757dc5a5 Yunfei Dong 2021-08-06 657 } 06fa5f757dc5a5 Yunfei Dong 2021-08-06 658 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org