[p2pmem:p2pdma_dma_map_ops_rfc 16/17] drivers/pci/p2pdma.c:1098:35: sparse: sparse: symbol 'pci_p2pdma_vmops' was not declared. Should it be
12:33 p.m.
tree: https://github.com/sbates130272/linux-p2pmem.git p2pdma_dma_map_ops_rfc
head: 80a55e73c60d1f8f02b4371ef6b666323348566a
commit: 81ae7aadc3185d570a1fbcaee821865bacca1679 [16/17] PCI/P2PDMA: Introduce
pci_mmap_p2pmem()
config: x86_64-randconfig-s021-20210311 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-262-g5e674421-dirty
#
https://github.com/sbates130272/linux-p2pmem/commit/81ae7aadc3185d570a1fb...
git remote add p2pmem https://github.com/sbates130272/linux-p2pmem.git
git fetch --no-tags p2pmem p2pdma_dma_map_ops_rfc
git checkout 81ae7aadc3185d570a1fbcaee821865bacca1679
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
"sparse warnings: (new ones prefixed by >>)"
> drivers/pci/p2pdma.c:1098:35: sparse: sparse: symbol
'pci_p2pdma_vmops' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
12:33 p.m.
New subject: [RFC PATCH p2pmem] PCI/P2PDMA: pci_p2pdma_vmops can be static
Fixes: 81ae7aadc318 ("PCI/P2PDMA: Introduce pci_mmap_p2pmem()")
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
p2pdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
index 152ce29666f68..241b98739c22a 100644
--- a/drivers/pci/p2pdma.c
+++ b/drivers/pci/p2pdma.c
@@ -1095,7 +1095,7 @@ static void pci_p2pdma_vma_close(struct vm_area_struct *vma)
kref_put(&pmap->ref, pci_p2pdma_map_free);
}
-const struct vm_operations_struct pci_p2pdma_vmops = {
+static const struct vm_operations_struct pci_p2pdma_vmops = {
.open = pci_p2pdma_vma_open,
.close = pci_p2pdma_vma_close,
};
558
days inactive
558
days old
1 comments
1 participants
participants (1)
-
kernel test robot