Hi Helen, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v5.6-rc6 next-20200316] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Helen-Koike/media-add-v4l2_pipel... base: git://linuxtv.org/media_tree.git master config: s390-randconfig-a001-20200316 (attached as .config) compiler: s390-linux-gcc (GCC) 9.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=9.2.0 make.cross ARCH=s390 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com&gt; All error/warnings (new ones prefixed by >>): | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/kernel.h:987:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~~~~~~ include/linux/kernel.h:987:20: note: in expansion of macro '__same_type' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~ include/media/v4l2-subdev.h:888:3: note: in expansion of macro 'container_of' 888 | container_of(__me_sd_ent, struct v4l2_subdev, entity) : \ | ^~~~~~~~~~~~ drivers/media/v4l2-core/v4l2-common.c:469:8: note: in expansion of macro 'media_entity_to_v4l2_subdev' 469 | sd = media_entity_to_v4l2_subdev(entity); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:987:51: error: 'struct v4l2_subdev' has no member named 'entity' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~ include/linux/compiler.h:58:61: note: in definition of macro '__trace_if_var' 58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) | ^~~~ include/linux/compiler.h:330:3: note: in expansion of macro 'if' 330 | if (!(condition)) \ | ^~ include/linux/compiler.h:338:2: note: in expansion of macro '__compiletime_assert' 338 | __compiletime_assert(condition, msg, prefix, suffix) | ^~~~~~~~~~~~~~~~~~~~ include/linux/compiler.h:350:2: note: in expansion of macro '_compiletime_assert' 350 | _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/kernel.h:987:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~~~~~~ include/linux/kernel.h:987:20: note: in expansion of macro '__same_type' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~ include/media/v4l2-subdev.h:888:3: note: in expansion of macro 'container_of' 888 | container_of(__me_sd_ent, struct v4l2_subdev, entity) : \ | ^~~~~~~~~~~~ drivers/media/v4l2-core/v4l2-common.c:469:8: note: in expansion of macro 'media_entity_to_v4l2_subdev' 469 | sd = media_entity_to_v4l2_subdev(entity); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:987:51: error: 'struct v4l2_subdev' has no member named 'entity' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~ include/linux/compiler.h:69:3: note: in definition of macro '__trace_if_value' 69 | (cond) ? \ | ^~~~ include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var' 56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~~~~~~~~~~~~~ include/linux/compiler.h:330:3: note: in expansion of macro 'if' 330 | if (!(condition)) \ | ^~ include/linux/compiler.h:338:2: note: in expansion of macro '__compiletime_assert' 338 | __compiletime_assert(condition, msg, prefix, suffix) | ^~~~~~~~~~~~~~~~~~~~ include/linux/compiler.h:350:2: note: in expansion of macro '_compiletime_assert' 350 | _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/kernel.h:987:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~~~~~~ include/linux/kernel.h:987:20: note: in expansion of macro '__same_type' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~ include/media/v4l2-subdev.h:888:3: note: in expansion of macro 'container_of' 888 | container_of(__me_sd_ent, struct v4l2_subdev, entity) : \ | ^~~~~~~~~~~~ drivers/media/v4l2-core/v4l2-common.c:469:8: note: in expansion of macro 'media_entity_to_v4l2_subdev' 469 | sd = media_entity_to_v4l2_subdev(entity); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from <command-line>: include/linux/compiler_types.h:129:35: error: 'struct v4l2_subdev' has no member named 'entity' 129 | #define __compiler_offsetof(a, b) __builtin_offsetof(a, b) | ^~~~~~~~~~~~~~~~~~ include/linux/stddef.h:17:32: note: in expansion of macro '__compiler_offsetof' 17 | #define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE, MEMBER) | ^~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:990:21: note: in expansion of macro 'offsetof' 990 | ((type *)(__mptr - offsetof(type, member))); }) | ^~~~~~~~ include/media/v4l2-subdev.h:888:3: note: in expansion of macro 'container_of' 888 | container_of(__me_sd_ent, struct v4l2_subdev, entity) : \ | ^~~~~~~~~~~~ drivers/media/v4l2-core/v4l2-common.c:469:8: note: in expansion of macro 'media_entity_to_v4l2_subdev' 469 | sd = media_entity_to_v4l2_subdev(entity); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/module.h:12, from drivers/media/v4l2-core/v4l2-common.c:37: drivers/media/v4l2-core/v4l2-common.c: At top level: 56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~ 485 | if (!pipe->streaming_count) | ^~ 72 | }) | ^ include/linux/compiler.h:58:69: note: in expansion of macro '__trace_if_value' 58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) | ^~~~~~~~~~~~~~~~ include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var' 56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~~~~~~~~~~~~~ 485 | if (!pipe->streaming_count) | ^~ drivers/media/v4l2-core/v4l2-common.c:488:15: error: expected declaration specifiers or '...' before '&' token 488 | mutex_unlock(&mdev->graph_mutex); | ^ drivers/media/v4l2-core/v4l2-common.c:490:2: error: expected identifier or '(' before 'return' 490 | return ret; | ^~~~~~ drivers/media/v4l2-core/v4l2-common.c:491:1: error: expected identifier or '(' before '}' token 491 | } | ^ In file included from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/module.h:12, from drivers/media/v4l2-core/v4l2-common.c:37: drivers/media/v4l2-core/v4l2-common.c: In function 'v4l2_pipeline_stream_enable': include/linux/kernel.h:987:51: error: 'struct v4l2_subdev' has no member named 'entity' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~ include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var' 58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) | ^~~~ include/linux/compiler.h:330:3: note: in expansion of macro 'if' 330 | if (!(condition)) \ | ^~ include/linux/compiler.h:338:2: note: in expansion of macro '__compiletime_assert' 338 | __compiletime_assert(condition, msg, prefix, suffix) | ^~~~~~~~~~~~~~~~~~~~ include/linux/compiler.h:350:2: note: in expansion of macro '_compiletime_assert' 350 | _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/kernel.h:987:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~~~~~~ include/linux/kernel.h:987:20: note: in expansion of macro '__same_type' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~ include/media/v4l2-subdev.h:888:3: note: in expansion of macro 'container_of' 888 | container_of(__me_sd_ent, struct v4l2_subdev, entity) : \ | ^~~~~~~~~~~~ drivers/media/v4l2-core/v4l2-common.c:518:8: note: in expansion of macro 'media_entity_to_v4l2_subdev' 518 | sd = media_entity_to_v4l2_subdev(entity); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:987:51: error: 'struct v4l2_subdev' has no member named 'entity' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~ include/linux/compiler.h:58:61: note: in definition of macro '__trace_if_var' 58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) | ^~~~ include/linux/compiler.h:330:3: note: in expansion of macro 'if' 330 | if (!(condition)) \ | ^~ include/linux/compiler.h:338:2: note: in expansion of macro '__compiletime_assert' 338 | __compiletime_assert(condition, msg, prefix, suffix) | ^~~~~~~~~~~~~~~~~~~~ include/linux/compiler.h:350:2: note: in expansion of macro '_compiletime_assert' 350 | _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/kernel.h:987:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~~~~~~ include/linux/kernel.h:987:20: note: in expansion of macro '__same_type' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~ include/media/v4l2-subdev.h:888:3: note: in expansion of macro 'container_of' 888 | container_of(__me_sd_ent, struct v4l2_subdev, entity) : \ | ^~~~~~~~~~~~ drivers/media/v4l2-core/v4l2-common.c:518:8: note: in expansion of macro 'media_entity_to_v4l2_subdev' 518 | sd = media_entity_to_v4l2_subdev(entity); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:987:51: error: 'struct v4l2_subdev' has no member named 'entity' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~ include/linux/compiler.h:69:3: note: in definition of macro '__trace_if_value' 69 | (cond) ? \ | ^~~~ include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var' 56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~~~~~~~~~~~~~ include/linux/compiler.h:330:3: note: in expansion of macro 'if' 330 | if (!(condition)) \ | ^~ include/linux/compiler.h:338:2: note: in expansion of macro '__compiletime_assert' 338 | __compiletime_assert(condition, msg, prefix, suffix) | ^~~~~~~~~~~~~~~~~~~~ include/linux/compiler.h:350:2: note: in expansion of macro '_compiletime_assert' 350 | _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/kernel.h:987:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~~~~~~ include/linux/kernel.h:987:20: note: in expansion of macro '__same_type' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~ include/media/v4l2-subdev.h:888:3: note: in expansion of macro 'container_of' 888 | container_of(__me_sd_ent, struct v4l2_subdev, entity) : \ | ^~~~~~~~~~~~ drivers/media/v4l2-core/v4l2-common.c:518:8: note: in expansion of macro 'media_entity_to_v4l2_subdev' 518 | sd = media_entity_to_v4l2_subdev(entity); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from <command-line>: include/linux/compiler_types.h:129:35: error: 'struct v4l2_subdev' has no member named 'entity' 129 | #define __compiler_offsetof(a, b) __builtin_offsetof(a, b) | ^~~~~~~~~~~~~~~~~~ include/linux/stddef.h:17:32: note: in expansion of macro '__compiler_offsetof' 17 | #define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE, MEMBER) | ^~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:990:21: note: in expansion of macro 'offsetof' 990 | ((type *)(__mptr - offsetof(type, member))); }) | ^~~~~~~~ include/media/v4l2-subdev.h:888:3: note: in expansion of macro 'container_of' 888 | container_of(__me_sd_ent, struct v4l2_subdev, entity) : \ | ^~~~~~~~~~~~ drivers/media/v4l2-core/v4l2-common.c:518:8: note: in expansion of macro 'media_entity_to_v4l2_subdev' 518 | sd = media_entity_to_v4l2_subdev(entity); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/module.h:12, from drivers/media/v4l2-core/v4l2-common.c:37: drivers/media/v4l2-core/v4l2-common.c: At top level: 56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~ drivers/media/v4l2-core/v4l2-common.c:535:2: note: in expansion of macro 'if' 535 | if (!pipe->streaming_count) | ^~ 72 | }) | ^ include/linux/compiler.h:58:69: note: in expansion of macro '__trace_if_value' 58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) | ^~~~~~~~~~~~~~~~ include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var' 56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~~~~~~~~~~~~~ drivers/media/v4l2-core/v4l2-common.c:535:2: note: in expansion of macro 'if' 535 | if (!pipe->streaming_count) | ^~ drivers/media/v4l2-core/v4l2-common.c:538:15: error: expected declaration specifiers or '...' before '&' token 538 | mutex_unlock(&mdev->graph_mutex); | ^ drivers/media/v4l2-core/v4l2-common.c:540:2: error: expected identifier or '(' before 'return' 540 | return ret; | ^~~~~~ drivers/media/v4l2-core/v4l2-common.c:541:1: error: expected identifier or '(' before '}' token 541 | } | ^ drivers/media/v4l2-core/v4l2-common.c: In function 'v4l2_pipeline_stream_disable': drivers/media/v4l2-core/v4l2-common.c:483:2: warning: control reaches end of non-void function [-Wreturn-type] 483 | } | ^ drivers/media/v4l2-core/v4l2-common.c: In function 'v4l2_pipeline_stream_enable': drivers/media/v4l2-core/v4l2-common.c:533:2: warning: control reaches end of non-void function [-Wreturn-type] 533 | } | ^ -- | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/kernel.h:987:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~~~~~~ include/linux/kernel.h:987:20: note: in expansion of macro '__same_type' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~ include/media/v4l2-subdev.h:888:3: note: in expansion of macro 'container_of' 888 | container_of(__me_sd_ent, struct v4l2_subdev, entity) : \ | ^~~~~~~~~~~~ drivers/media//v4l2-core/v4l2-common.c:469:8: note: in expansion of macro 'media_entity_to_v4l2_subdev' 469 | sd = media_entity_to_v4l2_subdev(entity); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:987:51: error: 'struct v4l2_subdev' has no member named 'entity' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~ include/linux/compiler.h:58:61: note: in definition of macro '__trace_if_var' 58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) | ^~~~ include/linux/compiler.h:330:3: note: in expansion of macro 'if' 330 | if (!(condition)) \ | ^~ include/linux/compiler.h:338:2: note: in expansion of macro '__compiletime_assert' 338 | __compiletime_assert(condition, msg, prefix, suffix) | ^~~~~~~~~~~~~~~~~~~~ include/linux/compiler.h:350:2: note: in expansion of macro '_compiletime_assert' 350 | _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/kernel.h:987:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~~~~~~ include/linux/kernel.h:987:20: note: in expansion of macro '__same_type' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~ include/media/v4l2-subdev.h:888:3: note: in expansion of macro 'container_of' 888 | container_of(__me_sd_ent, struct v4l2_subdev, entity) : \ | ^~~~~~~~~~~~ drivers/media//v4l2-core/v4l2-common.c:469:8: note: in expansion of macro 'media_entity_to_v4l2_subdev' 469 | sd = media_entity_to_v4l2_subdev(entity); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:987:51: error: 'struct v4l2_subdev' has no member named 'entity' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~ include/linux/compiler.h:69:3: note: in definition of macro '__trace_if_value' 69 | (cond) ? \ | ^~~~ include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var' 56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~~~~~~~~~~~~~ include/linux/compiler.h:330:3: note: in expansion of macro 'if' 330 | if (!(condition)) \ | ^~ include/linux/compiler.h:338:2: note: in expansion of macro '__compiletime_assert' 338 | __compiletime_assert(condition, msg, prefix, suffix) | ^~~~~~~~~~~~~~~~~~~~ include/linux/compiler.h:350:2: note: in expansion of macro '_compiletime_assert' 350 | _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/kernel.h:987:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~~~~~~ include/linux/kernel.h:987:20: note: in expansion of macro '__same_type' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~ include/media/v4l2-subdev.h:888:3: note: in expansion of macro 'container_of' 888 | container_of(__me_sd_ent, struct v4l2_subdev, entity) : \ | ^~~~~~~~~~~~ drivers/media//v4l2-core/v4l2-common.c:469:8: note: in expansion of macro 'media_entity_to_v4l2_subdev' 469 | sd = media_entity_to_v4l2_subdev(entity); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from <command-line>: include/linux/compiler_types.h:129:35: error: 'struct v4l2_subdev' has no member named 'entity' 129 | #define __compiler_offsetof(a, b) __builtin_offsetof(a, b) | ^~~~~~~~~~~~~~~~~~ include/linux/stddef.h:17:32: note: in expansion of macro '__compiler_offsetof' 17 | #define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE, MEMBER) | ^~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:990:21: note: in expansion of macro 'offsetof' 990 | ((type *)(__mptr - offsetof(type, member))); }) | ^~~~~~~~ include/media/v4l2-subdev.h:888:3: note: in expansion of macro 'container_of' 888 | container_of(__me_sd_ent, struct v4l2_subdev, entity) : \ | ^~~~~~~~~~~~ drivers/media//v4l2-core/v4l2-common.c:469:8: note: in expansion of macro 'media_entity_to_v4l2_subdev' 469 | sd = media_entity_to_v4l2_subdev(entity); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/module.h:12, from drivers/media//v4l2-core/v4l2-common.c:37: drivers/media//v4l2-core/v4l2-common.c: At top level: 56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~ drivers/media//v4l2-core/v4l2-common.c:485:2: note: in expansion of macro 'if' 485 | if (!pipe->streaming_count) | ^~ 72 | }) | ^ include/linux/compiler.h:58:69: note: in expansion of macro '__trace_if_value' 58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) | ^~~~~~~~~~~~~~~~ include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var' 56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~~~~~~~~~~~~~ drivers/media//v4l2-core/v4l2-common.c:485:2: note: in expansion of macro 'if' 485 | if (!pipe->streaming_count) | ^~ drivers/media//v4l2-core/v4l2-common.c:488:15: error: expected declaration specifiers or '...' before '&' token 488 | mutex_unlock(&mdev->graph_mutex); | ^ drivers/media//v4l2-core/v4l2-common.c:490:2: error: expected identifier or '(' before 'return' 490 | return ret; | ^~~~~~ drivers/media//v4l2-core/v4l2-common.c:491:1: error: expected identifier or '(' before '}' token 491 | } | ^ In file included from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/module.h:12, from drivers/media//v4l2-core/v4l2-common.c:37: drivers/media//v4l2-core/v4l2-common.c: In function 'v4l2_pipeline_stream_enable': include/linux/kernel.h:987:51: error: 'struct v4l2_subdev' has no member named 'entity' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~ include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var' 58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) | ^~~~ include/linux/compiler.h:330:3: note: in expansion of macro 'if' 330 | if (!(condition)) \ | ^~ include/linux/compiler.h:338:2: note: in expansion of macro '__compiletime_assert' 338 | __compiletime_assert(condition, msg, prefix, suffix) | ^~~~~~~~~~~~~~~~~~~~ include/linux/compiler.h:350:2: note: in expansion of macro '_compiletime_assert' 350 | _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/kernel.h:987:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~~~~~~ include/linux/kernel.h:987:20: note: in expansion of macro '__same_type' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~ include/media/v4l2-subdev.h:888:3: note: in expansion of macro 'container_of' 888 | container_of(__me_sd_ent, struct v4l2_subdev, entity) : \ | ^~~~~~~~~~~~ drivers/media//v4l2-core/v4l2-common.c:518:8: note: in expansion of macro 'media_entity_to_v4l2_subdev' 518 | sd = media_entity_to_v4l2_subdev(entity); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:987:51: error: 'struct v4l2_subdev' has no member named 'entity' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~ include/linux/compiler.h:58:61: note: in definition of macro '__trace_if_var' 58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) | ^~~~ include/linux/compiler.h:330:3: note: in expansion of macro 'if' 330 | if (!(condition)) \ | ^~ include/linux/compiler.h:338:2: note: in expansion of macro '__compiletime_assert' 338 | __compiletime_assert(condition, msg, prefix, suffix) | ^~~~~~~~~~~~~~~~~~~~ include/linux/compiler.h:350:2: note: in expansion of macro '_compiletime_assert' 350 | _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/kernel.h:987:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~~~~~~ include/linux/kernel.h:987:20: note: in expansion of macro '__same_type' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~ include/media/v4l2-subdev.h:888:3: note: in expansion of macro 'container_of' 888 | container_of(__me_sd_ent, struct v4l2_subdev, entity) : \ | ^~~~~~~~~~~~ drivers/media//v4l2-core/v4l2-common.c:518:8: note: in expansion of macro 'media_entity_to_v4l2_subdev' 518 | sd = media_entity_to_v4l2_subdev(entity); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:987:51: error: 'struct v4l2_subdev' has no member named 'entity' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~ include/linux/compiler.h:69:3: note: in definition of macro '__trace_if_value' 69 | (cond) ? \ | ^~~~ include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var' 56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~~~~~~~~~~~~~ include/linux/compiler.h:330:3: note: in expansion of macro 'if' 330 | if (!(condition)) \ | ^~ include/linux/compiler.h:338:2: note: in expansion of macro '__compiletime_assert' 338 | __compiletime_assert(condition, msg, prefix, suffix) | ^~~~~~~~~~~~~~~~~~~~ include/linux/compiler.h:350:2: note: in expansion of macro '_compiletime_assert' 350 | _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/kernel.h:987:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~~~~~~ include/linux/kernel.h:987:20: note: in expansion of macro '__same_type' 987 | BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ | ^~~~~~~~~~~ include/media/v4l2-subdev.h:888:3: note: in expansion of macro 'container_of' 888 | container_of(__me_sd_ent, struct v4l2_subdev, entity) : \ | ^~~~~~~~~~~~ drivers/media//v4l2-core/v4l2-common.c:518:8: note: in expansion of macro 'media_entity_to_v4l2_subdev' 518 | sd = media_entity_to_v4l2_subdev(entity); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from <command-line>: include/linux/compiler_types.h:129:35: error: 'struct v4l2_subdev' has no member named 'entity' 129 | #define __compiler_offsetof(a, b) __builtin_offsetof(a, b) | ^~~~~~~~~~~~~~~~~~ include/linux/stddef.h:17:32: note: in expansion of macro '__compiler_offsetof' 17 | #define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE, MEMBER) | ^~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:990:21: note: in expansion of macro 'offsetof' 990 | ((type *)(__mptr - offsetof(type, member))); }) | ^~~~~~~~ include/media/v4l2-subdev.h:888:3: note: in expansion of macro 'container_of' 888 | container_of(__me_sd_ent, struct v4l2_subdev, entity) : \ | ^~~~~~~~~~~~ drivers/media//v4l2-core/v4l2-common.c:518:8: note: in expansion of macro 'media_entity_to_v4l2_subdev' 518 | sd = media_entity_to_v4l2_subdev(entity); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/module.h:12, from drivers/media//v4l2-core/v4l2-common.c:37: drivers/media//v4l2-core/v4l2-common.c: At top level: 56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~ drivers/media//v4l2-core/v4l2-common.c:535:2: note: in expansion of macro 'if' 535 | if (!pipe->streaming_count) | ^~ 72 | }) | ^ include/linux/compiler.h:58:69: note: in expansion of macro '__trace_if_value' 58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) | ^~~~~~~~~~~~~~~~ include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var' 56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~~~~~~~~~~~~~ drivers/media//v4l2-core/v4l2-common.c:535:2: note: in expansion of macro 'if' 535 | if (!pipe->streaming_count) | ^~ drivers/media//v4l2-core/v4l2-common.c:538:15: error: expected declaration specifiers or '...' before '&' token 538 | mutex_unlock(&mdev->graph_mutex); | ^ drivers/media//v4l2-core/v4l2-common.c:540:2: error: expected identifier or '(' before 'return' 540 | return ret; | ^~~~~~ drivers/media//v4l2-core/v4l2-common.c:541:1: error: expected identifier or '(' before '}' token 541 | } | ^ drivers/media//v4l2-core/v4l2-common.c: In function 'v4l2_pipeline_stream_disable': drivers/media//v4l2-core/v4l2-common.c:483:2: warning: control reaches end of non-void function [-Wreturn-type] 483 | } | ^ drivers/media//v4l2-core/v4l2-common.c: In function 'v4l2_pipeline_stream_enable': drivers/media//v4l2-core/v4l2-common.c:533:2: warning: control reaches end of non-void function [-Wreturn-type] 533 | } | ^ vim +/if +485 drivers/media/v4l2-core/v4l2-common.c 444 445 int v4l2_pipeline_stream_disable(struct media_entity *entity, 446 struct media_pipeline *pipe) 447 { 448 struct media_device *mdev = entity->graph_obj.mdev; 449 int ret = 0; 450 451 mutex_lock(&mdev->graph_mutex); 452 453 if (!pipe->streaming_count) { 454 ret = media_graph_walk_init(&pipe->graph, mdev); 455 if (ret) { 456 mutex_unlock(&mdev->graph_mutex); 457 return ret; 458 } 459 } 460 461 media_graph_walk_start(&pipe->graph, entity); 462 463 while ((entity = media_graph_walk_next_stream(&pipe->graph))) { 464 struct v4l2_subdev *sd; 465 466 if (!is_media_entity_v4l2_subdev(entity)) 467 continue; 468 469 sd = media_entity_to_v4l2_subdev(entity); 470 if (!sd->stream_count || --sd->stream_count) 471 continue; 472 473 ret = v4l2_subdev_call(sd, video, s_stream, false); 474 if (ret && ret != -ENOIOCTLCMD) 475 dev_dbg(mdev->dev, 476 "couldn't disable stream for subdevice '%s'\n", 477 entity->name); 478 break; 479 } 480 481 dev_dbg(mdev->dev, 482 "stream disabled for subdevice '%s'\n", entity->name); 483 } 484 486 media_graph_walk_cleanup(&pipe->graph); 487 488 mutex_unlock(&mdev->graph_mutex); 489 490 return ret; 491 } 492 EXPORT_SYMBOL_GPL(v4l2_pipeline_stream_disable); 493 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org