Hi Leonard,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on 1fe5b01262844be03de98afdd56d1d393df04d7e]
url:
https://github.com/0day-ci/linux/commits/Leonard-Crestez/tcp-Initial-supp...
base: 1fe5b01262844be03de98afdd56d1d393df04d7e
config: openrisc-randconfig-r014-20211208
(
https://download.01.org/0day-ci/archive/20211209/202112090528.v4sYAZMH-lk...)
compiler: or1k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/c40d052f30af7bd56b0803412e4f39153...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Leonard-Crestez/tcp-Initial-support-for-RFC5925-auth-option/20211208-194125
git checkout c40d052f30af7bd56b0803412e4f391532253116
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir
ARCH=openrisc SHELL=/bin/bash net/ipv4/ net/ipv6/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
net/ipv6/tcp_ipv6.c: In function 'tcp_v6_send_response':
> net/ipv6/tcp_ipv6.c:931:66: warning: parameter 'key' set
but not used [-Wunused-but-set-parameter]
931 |
int oif, struct tcp_md5sig_key *key, int rst,
| ~~~~~~~~~~~~~~~~~~~~~~~^~~
vim +/key +931 net/ipv6/tcp_ipv6.c
c40d052f30af7b Leonard Crestez 2021-12-08 928
a00e74442bac5a Eric Dumazet 2015-09-29 929 static void tcp_v6_send_response(const
struct sock *sk, struct sk_buff *skb, u32 seq,
0f85feae6b710c Eric Dumazet 2014-12-09 930 u32 ack, u32 win, u32 tsval, u32
tsecr,
0f85feae6b710c Eric Dumazet 2014-12-09 @931 int oif, struct tcp_md5sig_key
*key, int rst,
e9a5dceee56cb5 Eric Dumazet 2019-09-24 932 u8 tclass, __be32 label, u32
priority)
^1da177e4c3f41 Linus Torvalds 2005-04-16 933 {
cf533ea53ebfae Eric Dumazet 2011-10-21 934 const struct tcphdr *th =
tcp_hdr(skb);
cf533ea53ebfae Eric Dumazet 2011-10-21 935 struct tcphdr *t1;
^1da177e4c3f41 Linus Torvalds 2005-04-16 936 struct sk_buff *buff;
4c9483b2fb5d25 David S. Miller 2011-03-12 937 struct flowi6 fl6;
0f85feae6b710c Eric Dumazet 2014-12-09 938 struct net *net = sk ? sock_net(sk) :
dev_net(skb_dst(skb)->dev);
e504799276e530 Daniel Lezcano 2008-03-07 939 struct sock *ctl_sk =
net->ipv6.tcp_sk;
77c676da1b717e Ilpo Järvinen 2008-10-09 940 unsigned int tot_len = sizeof(struct
tcphdr);
dc87efdb1a5cd4 Florian Westphal 2021-04-01 941 __be32 mrst = 0, *topt;
adf30907d63893 Eric Dumazet 2009-06-02 942 struct dst_entry *dst;
00483690552c5f Jon Maxwell 2018-05-10 943 __u32 mark = 0;
c40d052f30af7b Leonard Crestez 2021-12-08 944 #ifdef CONFIG_TCP_AUTHOPT
c40d052f30af7b Leonard Crestez 2021-12-08 945 struct tcp_authopt_info *aoinfo;
c40d052f30af7b Leonard Crestez 2021-12-08 946 struct tcp_authopt_key_info *aokey;
c40d052f30af7b Leonard Crestez 2021-12-08 947 u8 aornextkeyid;
c40d052f30af7b Leonard Crestez 2021-12-08 948 int aolen;
c40d052f30af7b Leonard Crestez 2021-12-08 949 #endif
^1da177e4c3f41 Linus Torvalds 2005-04-16 950
ee684b6f283004 Andrey Vagin 2013-02-11 951 if (tsecr)
626e264dd1989b Ilpo Järvinen 2008-10-09 952 tot_len += TCPOLEN_TSTAMP_ALIGNED;
c40d052f30af7b Leonard Crestez 2021-12-08 953 #ifdef CONFIG_TCP_AUTHOPT
c40d052f30af7b Leonard Crestez 2021-12-08 954 /* Key lookup before SKB allocation */
c40d052f30af7b Leonard Crestez 2021-12-08 955 aolen =
tcp_v6_send_response_init_authopt(sk, &aoinfo, &aokey, &aornextkeyid);
c40d052f30af7b Leonard Crestez 2021-12-08 956 if (aolen) {
c40d052f30af7b Leonard Crestez 2021-12-08 957 tot_len += aolen;
c40d052f30af7b Leonard Crestez 2021-12-08 958 /* Don't use MD5 */
c40d052f30af7b Leonard Crestez 2021-12-08 959 key = NULL;
c40d052f30af7b Leonard Crestez 2021-12-08 960 }
c40d052f30af7b Leonard Crestez 2021-12-08 961 #endif
cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 962 #ifdef CONFIG_TCP_MD5SIG
cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 963 if (key)
cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 964 tot_len += TCPOLEN_MD5SIG_ALIGNED;
cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 965 #endif
cfb6eeb4c86059 YOSHIFUJI Hideaki 2006-11-14 966
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org