[morse:mpam/snapshot/v5.15 46/139] arch/x86/kernel/cpu/resctrl/core.c:34:1: sparse: sparse: symbol 'domain_list_lock' was not declared. Should it be static?
11:24 a.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git
mpam/snapshot/v5.15
head: ce3629841262f725a5f3a327403fcaf0e604a85e
commit: 63dc771f72401f998123fca77456c2ef652f1fa6 [46/139] x86/resctrl: Split arch and fs
resctrl locks
config: i386-randconfig-s002-20211116 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
#
https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git/commit/?i...
git remote add morse
https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git
git fetch --no-tags morse mpam/snapshot/v5.15
git checkout 63dc771f72401f998123fca77456c2ef652f1fa6
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir
ARCH=i386 SHELL=/bin/bash arch/x86/kernel/cpu/resctrl/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
> arch/x86/kernel/cpu/resctrl/core.c:34:1: sparse: sparse: symbol
'domain_list_lock' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
11:25 a.m.
New subject: [RFC PATCH morse] x86/resctrl: domain_list_lock can be static
arch/x86/kernel/cpu/resctrl/core.c:34:1: warning: symbol 'domain_list_lock' was
not declared. Should it be static?
Fixes: 63dc771f7240 ("x86/resctrl: Split arch and fs resctrl locks")
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
index ae5d9e2d20b3b2..439078c4a676b3 100644
--- a/arch/x86/kernel/cpu/resctrl/core.c
+++ b/arch/x86/kernel/cpu/resctrl/core.c
@@ -31,7 +31,7 @@
* The rdt_resource's domain list is updated when this happens. The domain
* list is protected by cpuhp as a rwlock, writers also take this mutex.
*/
-DEFINE_MUTEX(domain_list_lock);
+static DEFINE_MUTEX(domain_list_lock);
/*
* The cached resctrl_pqr_state is strictly per CPU and can never be
307
days inactive
307
days old
1 comments
1 participants
participants (1)
-
kernel test robot