[android-common:android-4.19-stable 14939/24734] kernel/power/qos.c:306:5: warning: stack frame size (33208) exceeds limit (8192) in 'pm_qos_update_target'
2:36 a.m.
Hi Lina,
FYI, the error/warning still remains.
tree: https://android.googlesource.com/kernel/common android-4.19-stable
head: 523769c68b7ba74a9ec329ba0c5d03f57ecbd83a
commit: 723feab600f71b3104a10de5b372bd1d9adf5943 [14939/24734] ANDROID: GKI: QoS: Enhance
framework to support cpu/irq specific QoS requests
config: x86_64-randconfig-a004-20211101
(https://download.01.org/0day-ci/archive/20220110/202201102336.wGazlOWj-lk...)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
264d3b6d4e08401c5b50a85bd76e80b3461d77e6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add android-common https://android.googlesource.com/kernel/common
git fetch --no-tags android-common android-4.19-stable
git checkout 723feab600f71b3104a10de5b372bd1d9adf5943
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir
ARCH=x86_64 SHELL=/bin/bash kernel/power/ sound/soc/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> kernel/power/qos.c:306:5: warning: stack frame size (33208)
exceeds limit (8192) in 'pm_qos_update_target' [-Wframe-larger-than]
int
pm_qos_update_target(struct pm_qos_constraints *c, struct plist_node *node,
^
1 warning generated.
kernel/power/qos.c:630: warning: Function parameter or member 'new_value' not
described in 'pm_qos_update_request'
kernel/power/qos.c:630: warning: Excess function parameter 'value' description
in 'pm_qos_update_request'
vim +/pm_qos_update_target +306 kernel/power/qos.c
723feab600f71b kernel/power/qos.c Lina Iyer 2014-05-21 294
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 295 /**
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 296 *
pm_qos_update_target - manages the constraints list and calls the notifiers
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 297 * if needed
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 298 * @c:
constraints data struct
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 299 * @node:
request to add to the list, to update or to remove
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 300 * @action:
action to take on the constraints list
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 301 * @value:
value of the request to add or update
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 302 *
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 303 * This
function returns 1 if the aggregated constraint value has changed, 0
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 304 * otherwise.
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 305 */
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 @306 int
pm_qos_update_target(struct pm_qos_constraints *c, struct plist_node *node,
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 307 enum
pm_qos_req_action action, int value)
d82b35186eaa81 kernel/pm_qos_params.c Mark Gross 2008-02-04 308 {
d82b35186eaa81 kernel/pm_qos_params.c Mark Gross 2008-02-04 309 unsigned long
flags;
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 310 int
prev_value, curr_value, new_value;
2d984ad132a87c kernel/power/qos.c Rafael J. Wysocki 2014-02-11 311 int ret;
d82b35186eaa81 kernel/pm_qos_params.c Mark Gross 2008-02-04 312
d82b35186eaa81 kernel/pm_qos_params.c Mark Gross 2008-02-04 313
spin_lock_irqsave(&pm_qos_lock, flags);
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 314 prev_value =
pm_qos_get_value(c);
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 315 if (value ==
PM_QOS_DEFAULT_VALUE)
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 316 new_value =
c->default_value;
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 317 else
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 318 new_value =
value;
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 319
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 320 switch
(action) {
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 321 case
PM_QOS_REMOVE_REQ:
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 322
plist_del(node, &c->list);
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 323 break;
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 324 case
PM_QOS_UPDATE_REQ:
5f279845f9d684 kernel/pm_qos_params.c James Bottomley 2010-07-19 325 /*
5f279845f9d684 kernel/pm_qos_params.c James Bottomley 2010-07-19 326 * to change
the list, we atomically remove, reinit
5f279845f9d684 kernel/pm_qos_params.c James Bottomley 2010-07-19 327 * with new
value and add, then see if the extremal
5f279845f9d684 kernel/pm_qos_params.c James Bottomley 2010-07-19 328 * changed
5f279845f9d684 kernel/pm_qos_params.c James Bottomley 2010-07-19 329 */
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 330
plist_del(node, &c->list);
fe43e2ce526979 kernel/power/qos.c Gustavo A. R. Silva 2018-03-30 331 /* fall
through */
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 332 case
PM_QOS_ADD_REQ:
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 333
plist_node_init(node, new_value);
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 334
plist_add(node, &c->list);
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 335 break;
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 336 default:
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 337 /* no action
*/
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 338 ;
d82b35186eaa81 kernel/pm_qos_params.c Mark Gross 2008-02-04 339 }
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 340
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 341 curr_value =
pm_qos_get_value(c);
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 342
pm_qos_set_value(c, curr_value);
723feab600f71b kernel/power/qos.c Lina Iyer 2014-05-21 343
pm_qos_set_value_for_cpus(c);
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 344
d82b35186eaa81 kernel/pm_qos_params.c Mark Gross 2008-02-04 345
spin_unlock_irqrestore(&pm_qos_lock, flags);
d82b35186eaa81 kernel/pm_qos_params.c Mark Gross 2008-02-04 346
247e9ee034b044 kernel/power/qos.c Sahara 2013-06-21 347
trace_pm_qos_update_target(action, prev_value, curr_value);
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 348 if (prev_value
!= curr_value) {
2d984ad132a87c kernel/power/qos.c Rafael J. Wysocki 2014-02-11 349 ret = 1;
2d984ad132a87c kernel/power/qos.c Rafael J. Wysocki 2014-02-11 350 if
(c->notifiers)
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 351
blocking_notifier_call_chain(c->notifiers,
5f279845f9d684 kernel/pm_qos_params.c James Bottomley 2010-07-19 352
(unsigned long)curr_value,
5f279845f9d684 kernel/pm_qos_params.c James Bottomley 2010-07-19 353
NULL);
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 354 } else {
2d984ad132a87c kernel/power/qos.c Rafael J. Wysocki 2014-02-11 355 ret = 0;
abe98ec2d86279 kernel/power/qos.c Jean Pihet 2011-08-25 356 }
2d984ad132a87c kernel/power/qos.c Rafael J. Wysocki 2014-02-11 357 return ret;
d82b35186eaa81 kernel/pm_qos_params.c Mark Gross 2008-02-04 358 }
d82b35186eaa81 kernel/pm_qos_params.c Mark Gross 2008-02-04 359
:::::: The code at line 306 was first introduced by commit
:::::: abe98ec2d86279fe821c9051003a0abc43444f15 PM QoS: Generalize and export constraints
management code
:::::: TO: Jean Pihet <j-pihet(a)ti.com>
:::::: CC: Rafael J. Wysocki <rjw(a)sisk.pl>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
253
days inactive
253
days old
0 comments
1 participants
participants (1)
-
kernel test robot