Hi Lee, [FYI, it's a private test report for your RFC patch.] [auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on scsi/for-next v5.8-rc4 next-20200708] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Lee-Sang-Hyun/sd-drain-a-request... base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: x86_64-rhel (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): drivers/scsi/sd.c: In function 'sd_shutdown': 3567 | struct request_queue *q = sdp->request_queue; | ^~~ | sdkp drivers/scsi/sd.c:3567:28: note: each undeclared identifier is reported only once for each function it appears in In file included from include/linux/seqlock.h:36, from include/linux/time.h:6, from include/linux/stat.h:19, from include/linux/module.h:13, from drivers/scsi/sd.c:36: 3586 | spin_lock_irqsave(q->queue_lock, flags); | ~^~~~~~~~~~~~ | | | spinlock_t {aka struct spinlock} include/linux/spinlock.h:251:34: note: in definition of macro 'raw_spin_lock_irqsave' 251 | flags = _raw_spin_lock_irqsave(lock); \ | ^~~~ drivers/scsi/sd.c:3586:2: note: in expansion of macro 'spin_lock_irqsave' 3586 | spin_lock_irqsave(q->queue_lock, flags); | ^~~~~~~~~~~~~~~~~ In file included from include/linux/seqlock.h:36, from include/linux/time.h:6, from include/linux/stat.h:19, from include/linux/module.h:13, from drivers/scsi/sd.c:36: include/linux/spinlock.h:326:67: note: expected 'spinlock_t *' {aka 'struct spinlock *'} but argument is of type 'spinlock_t' {aka 'struct spinlock'} 326 | static __always_inline raw_spinlock_t *spinlock_check(spinlock_t *lock) | ~~~~~~~~~~~~^~~~ 3587 | queue_flag_set(QUEUE_FLAG_DYING, q); | ^~~~~~~~~~~~~~ | blk_queue_flag_set 3588 | __blk_drain_queue(q, true); | ^~~~~~~~~~~~~~~~~ 3590 | spin_unlock_irqrestore(q->queue_lock, flags); | ~^~~~~~~~~~~~ | | | spinlock_t {aka struct spinlock} In file included from include/linux/seqlock.h:36, from include/linux/time.h:6, from include/linux/stat.h:19, from include/linux/module.h:13, from drivers/scsi/sd.c:36: include/linux/spinlock.h:406:64: note: expected 'spinlock_t *' {aka 'struct spinlock *'} but argument is of type 'spinlock_t' {aka 'struct spinlock'} 406 | static __always_inline void spin_unlock_irqrestore(spinlock_t *lock, unsigned long flags) | ~~~~~~~~~~~~^~~~ cc1: some warnings being treated as errors vim +3567 drivers/scsi/sd.c 3558 3559 /* 3560 * Send a SYNCHRONIZE CACHE instruction down to the device through 3561 * the normal SCSI command structure. Wait for the command to 3562 * complete. 3563 */ 3564 static void sd_shutdown(struct device *dev) 3565 { 3566 struct scsi_disk *sdkp = dev_get_drvdata(dev); 3568 unsigned long flags; 3569 3570 if (!sdkp) 3571 return; /* this can happen */ 3572 3573 if (pm_runtime_suspended(dev)) 3574 return; 3575 3576 if (sdkp->WCE && sdkp->media_present) { 3577 sd_printk(KERN_NOTICE, sdkp, "Synchronizing SCSI cache\n"); 3578 sd_sync_cache(sdkp, NULL); 3579 } 3580 3581 if (system_state != SYSTEM_RESTART && sdkp->device->manage_start_stop) { 3582 sd_printk(KERN_NOTICE, sdkp, "Stopping disk\n"); 3583 sd_start_stop_device(sdkp, 0); 3584 } 3585 3589 queue_flag_set(QUEUE_FLAG_DEAD, q); 3591 } 3592 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org