CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Denis Efremov <efremov(a)linux.com&gt; CC: Julia Lawall <Julia.Lawall(a)lip6.fr&gt; CC: Brian King <brking(a)us.ibm.com&gt; CC: "James E.J. Bottomley" <jejb(a)linux.ibm.com&gt; CC: "Martin K. Petersen" <martin.petersen(a)oracle.com&gt; CC: linux-scsi(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot <lkp(a)intel.com&gt; drivers/scsi/ipr.c:4209:61-62: WARNING opportunity for kobj_to_dev() drivers/scsi/ipr.c:4185:61-62: WARNING opportunity for kobj_to_dev() drivers/scsi/ipr.c:4268:61-62: WARNING opportunity for kobj_to_dev() drivers/scsi/ipr.c:3459:60-61: WARNING opportunity for kobj_to_dev() drivers/scsi/ipr.c:4457:61-62: WARNING opportunity for kobj_to_dev() Use kobj_to_dev() instead of container_of() Generated by: scripts/coccinelle/api/kobj_to_dev.cocci Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") CC: Denis Efremov <efremov(a)linux.com&gt; Reported-by: kernel test robot <lkp(a)intel.com&gt; Signed-off-by: kernel test robot <lkp(a)intel.com&gt; --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5e46d1b78a03d52306f21f77a4e4a144b6d31486 commit: a2fc3718bc22e85378085568ecc5765fb28cabce coccinelle: api: add kobj_to_dev.cocci script :::::: branch date: 23 hours ago :::::: commit date: 7 months ago Please take the patch only if it's a positive warning. Thanks! ipr.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) --- a/drivers/scsi/ipr.c +++ b/drivers/scsi/ipr.c @@ -3456,7 +3456,7 @@ static ssize_t ipr_read_trace(struct fil struct bin_attribute *bin_attr, char *buf, loff_t off, size_t count) { - struct device *dev = container_of(kobj, struct device, kobj); + struct device *dev = kobj_to_dev(kobj); struct Scsi_Host *shost = class_to_shost(dev); struct ipr_ioa_cfg *ioa_cfg = (struct ipr_ioa_cfg *)shost->hostdata; unsigned long lock_flags = 0; @@ -4182,7 +4182,7 @@ static ssize_t ipr_read_async_err_log(st struct bin_attribute *bin_attr, char *buf, loff_t off, size_t count) { - struct device *cdev = container_of(kobj, struct device, kobj); + struct device *cdev = kobj_to_dev(kobj); struct Scsi_Host *shost = class_to_shost(cdev); struct ipr_ioa_cfg *ioa_cfg = (struct ipr_ioa_cfg *)shost->hostdata; struct ipr_hostrcb *hostrcb; @@ -4206,7 +4206,7 @@ static ssize_t ipr_next_async_err_log(st struct bin_attribute *bin_attr, char *buf, loff_t off, size_t count) { - struct device *cdev = container_of(kobj, struct device, kobj); + struct device *cdev = kobj_to_dev(kobj); struct Scsi_Host *shost = class_to_shost(cdev); struct ipr_ioa_cfg *ioa_cfg = (struct ipr_ioa_cfg *)shost->hostdata; struct ipr_hostrcb *hostrcb; @@ -4265,7 +4265,7 @@ static ssize_t ipr_read_dump(struct file struct bin_attribute *bin_attr, char *buf, loff_t off, size_t count) { - struct device *cdev = container_of(kobj, struct device, kobj); + struct device *cdev = kobj_to_dev(kobj); struct Scsi_Host *shost = class_to_shost(cdev); struct ipr_ioa_cfg *ioa_cfg = (struct ipr_ioa_cfg *)shost->hostdata; struct ipr_dump *dump; @@ -4454,7 +4454,7 @@ static ssize_t ipr_write_dump(struct fil struct bin_attribute *bin_attr, char *buf, loff_t off, size_t count) { - struct device *cdev = container_of(kobj, struct device, kobj); + struct device *cdev = kobj_to_dev(kobj); struct Scsi_Host *shost = class_to_shost(cdev); struct ipr_ioa_cfg *ioa_cfg = (struct ipr_ioa_cfg *)shost->hostdata; int rc;