Hi Christoph, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.9-rc2 next-20200828] [cannot apply to block/for-next ide/master driver-core/driver-core-testing] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Christoph-Hellwig/char_dev-repla... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1127b219ce9481c84edad9711626d856127d5e51 config: x86_64-randconfig-m001-20200830 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com&gt; New smatch warnings: drivers/block/floppy.c:4592 floppy_alloc_disk() warn: passing a valid pointer to 'PTR_ERR' # https://github.com/0day-ci/linux/commit/f08c4ae246f71af7908c08acf544e35dc... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Christoph-Hellwig/char_dev-replace-cdev_map-with-an-xarray/20200830-152505 git checkout f08c4ae246f71af7908c08acf544e35dcc4b672b vim +/PTR_ERR +4592 drivers/block/floppy.c f08c4ae246f71af Christoph Hellwig 2020-08-30 4581 static int floppy_alloc_disk(unsigned int drive, unsigned int type) ^1da177e4c3f415 Linus Torvalds 2005-04-16 4582 { f08c4ae246f71af Christoph Hellwig 2020-08-30 4583 struct gendisk *disk; f08c4ae246f71af Christoph Hellwig 2020-08-30 4584 int err; f08c4ae246f71af Christoph Hellwig 2020-08-30 4585 f08c4ae246f71af Christoph Hellwig 2020-08-30 4586 disk = alloc_disk(1); f08c4ae246f71af Christoph Hellwig 2020-08-30 4587 if (!disk) f08c4ae246f71af Christoph Hellwig 2020-08-30 4588 return -ENOMEM; f08c4ae246f71af Christoph Hellwig 2020-08-30 4589 f08c4ae246f71af Christoph Hellwig 2020-08-30 4590 disk->queue = blk_mq_init_queue(&tag_sets[drive]); f08c4ae246f71af Christoph Hellwig 2020-08-30 4591 if (IS_ERR(disk->queue)) { f08c4ae246f71af Christoph Hellwig 2020-08-30 @4592 err = PTR_ERR(disk); ^^^^^^^^^^^^^ err = PTR_ERR(disk->queue); f08c4ae246f71af Christoph Hellwig 2020-08-30 4593 disk->queue = NULL; f08c4ae246f71af Christoph Hellwig 2020-08-30 4594 put_disk(disk); f08c4ae246f71af Christoph Hellwig 2020-08-30 4595 return err; f08c4ae246f71af Christoph Hellwig 2020-08-30 4596 } f08c4ae246f71af Christoph Hellwig 2020-08-30 4597 f08c4ae246f71af Christoph Hellwig 2020-08-30 4598 blk_queue_bounce_limit(disk->queue, BLK_BOUNCE_HIGH); f08c4ae246f71af Christoph Hellwig 2020-08-30 4599 blk_queue_max_hw_sectors(disk->queue, 64); f08c4ae246f71af Christoph Hellwig 2020-08-30 4600 disk->major = FLOPPY_MAJOR; f08c4ae246f71af Christoph Hellwig 2020-08-30 4601 disk->first_minor = TOMINOR(drive) | (type << 2); f08c4ae246f71af Christoph Hellwig 2020-08-30 4602 disk->fops = &floppy_fops; f08c4ae246f71af Christoph Hellwig 2020-08-30 4603 disk->events = DISK_EVENT_MEDIA_CHANGE; f08c4ae246f71af Christoph Hellwig 2020-08-30 4604 if (type) f08c4ae246f71af Christoph Hellwig 2020-08-30 4605 sprintf(disk->disk_name, "fd%d_type%d", drive, type); f08c4ae246f71af Christoph Hellwig 2020-08-30 4606 else f08c4ae246f71af Christoph Hellwig 2020-08-30 4607 sprintf(disk->disk_name, "fd%d", drive); f08c4ae246f71af Christoph Hellwig 2020-08-30 4608 /* to be cleaned up... */ f08c4ae246f71af Christoph Hellwig 2020-08-30 4609 disk->private_data = (void *)(long)drive; f08c4ae246f71af Christoph Hellwig 2020-08-30 4610 disk->flags |= GENHD_FL_REMOVABLE; f08c4ae246f71af Christoph Hellwig 2020-08-30 4611 f08c4ae246f71af Christoph Hellwig 2020-08-30 4612 disks[drive][type] = disk; f08c4ae246f71af Christoph Hellwig 2020-08-30 4613 return 0; f08c4ae246f71af Christoph Hellwig 2020-08-30 4614 } --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org