[PATCH v2 0/5] DAX fsync/msync fixes
by Ross Zwisler
Changes from v1:
- Fixed a macro collision for "PMD_INDEX" reported by 0-day for the "tile"
architecture:
config: tile-allyesconfig (attached as .config)
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin... -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=tile
All warnings (new ones prefixed by >>):
>> fs/dax.c:330:0: warning: "PMD_INDEX" redefined [enabled by default]
arch/tile/include/asm/pgtable_64.h:35:0: note: this is the location of the previous definition
>> fs/dax.c:330:0: warning: "PMD_INDEX" redefined [enabled by default]
arch/tile/include/asm/pgtable_64.h:35:0: note: this is the location of the previous definition
Thanks, 0-day!
This set applies cleanly on top of v8 of my "DAX fsync/msync support" set,
which is in -mm and -next. That set has not yet been merged for v4.5
which is why the my work tree is still based on -next:
https://git.kernel.org/cgit/linux/kernel/git/zwisler/linux.git/log/?h=fsy...
---
Original summary:
This series fixes several issues in v8 of my "DAX fsync/msync support"
patch series [1]. Thank you to Jan Kara for his excellent review.
Jan pointed out that we probably have an issue with the way hole punch
interacts with the fsync/msync code. This is the item that I'll work on
next, but I wanted to send this series out now as I think it will be
independent of the hole punch fixes.
[1]: https://lists.01.org/pipermail/linux-nvdimm/2016-January/003952.html
Ross Zwisler (5):
dax: never rely on bh.b_dev being set by get_block()
dax: clear TOWRITE flag after flush is complete
dax: improve documentation for fsync/msync
dax: fix PMD handling for fsync/msync
dax: fix clearing of holes in __dax_pmd_fault()
fs/dax.c | 110 +++++++++++++++++++++++++++++++++++++++++++++++++--------------
1 file changed, 86 insertions(+), 24 deletions(-)
--
2.5.0
4 years, 9 months
[LSF/MM ATTEND] Persistent Memory Error Handling
by Vishal Verma
Hi,
I'd like to attend LSF/MM. My primary topic of interest is the above as
proposed by Jeff Moyer:
http://www.spinics.net/lists/linux-mm/msg100560.html
I wrote the initial enabling for error handling that was merged for 4.5
(Building a poison list in the libnvdimm subsystem, exposing it as
'badblocks'), and am working on subsequent improvements in this areaa.
These would include making the initial poison gathering asynchronous,
and finer grained DAX control instead of turning DAX off entirely in
the presence of poison which we currently do.
Another topic of discussion I'd like to propose within this session is
to explore if there are use cases that the now-generic badblocks
implementation can fit. There is at least one opportunity of
consolidation between md-raid's sysfs representation of badblocks, and
the generically available one in gendisk.
Thanks,
-Vishal
4 years, 9 months
[PATCH v3 0/5] DAX fsync/msync fixes
by Ross Zwisler
Changes from v2:
- Added a WARN_ON_ONCE() to dax_radix_entry() to enforce the assumption
that we never insert a PMD DAX entry that isn't dirty. (Jan)
- Added checks to ensure that 'entry' is non-NULL before passing it to
RADIX_DAX_TYPE(). This worked correclty before because RADIX_DAX_TYPE()
just checks the value of 'entry' and doesn't dereference it, but it
reads better and is less likely to cause unnecessary worry. (Jan)
- Added Reviewed-by tags from Jan & fixed a comment typo.
This set applies cleanly on top of v8 of my "DAX fsync/msync support" set,
which is in -mm and -next. That set has not yet been merged for v4.5
which is why the my work tree is still based on -next:
https://git.kernel.org/cgit/linux/kernel/git/zwisler/linux.git/log/?h=fsy...
---
Original summary:
This series fixes several issues in v8 of my "DAX fsync/msync support"
patch series [1]. Thank you to Jan Kara for his excellent review.
Jan pointed out that we probably have an issue with the way hole punch
interacts with the fsync/msync code. This is the item that I'll work on
next, but I wanted to send this series out now as I think it will be
independent of the hole punch fixes.
[1]: https://lists.01.org/pipermail/linux-nvdimm/2016-January/003952.html
Ross Zwisler (5):
dax: never rely on bh.b_dev being set by get_block()
dax: clear TOWRITE flag after flush is complete
dax: improve documentation for fsync/msync
dax: fix PMD handling for fsync/msync
dax: fix clearing of holes in __dax_pmd_fault()
fs/dax.c | 109 +++++++++++++++++++++++++++++++++++++++++++++++++--------------
1 file changed, 86 insertions(+), 23 deletions(-)
--
2.5.0
4 years, 9 months
Improve keywords ranks within few weeks
by Xmas.SEO.Offer＠mg-dot.cn
All SEO efforts are more successful when they are a part of the
powerful SEO campaign.
With the SEO Max package you can rest assured that your positions
will start getting higher.
If you take your business seriously this is an ideal solution for
you
http://www.mg-dot.cn/detail.php?id=117
Unsubscribe option is available on the footer of our website
4 years, 9 months
[PATCH] libnvdimm, nfit: Use ACPI_SIG_NFIT instead of hard coded string
by Lee, Chun-Yi
It's minor but that's still better to use ACPI_SIG_NFIT instead of hard
coded string.
Cc: Ross Zwisler <ross.zwisler(a)linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw(a)rjwysocki.net>
Cc: Len Brown <lenb(a)kernel.org>
Signed-off-by: Lee, Chun-Yi <jlee(a)suse.com>
---
drivers/acpi/nfit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c
index aa45d48..9fb1a6a 100644
--- a/drivers/acpi/nfit.c
+++ b/drivers/acpi/nfit.c
@@ -1739,7 +1739,7 @@ static int acpi_nfit_add(struct acpi_device *adev)
acpi_size sz;
int rc;
- status = acpi_get_table_with_size("NFIT", 0, &tbl, &sz);
+ status = acpi_get_table_with_size(ACPI_SIG_NFIT, 0, &tbl, &sz);
if (ACPI_FAILURE(status)) {
/* This is ok, we could have an nvdimm hotplugged later */
dev_dbg(dev, "failed to find NFIT at startup\n");
--
2.1.4
4 years, 9 months
[PATCH 0/5] DAX fsync/msync fixes
by Ross Zwisler
This series fixes several issues in v8 of my "DAX fsync/msync support"
patch series [1]. Thank you to Jan Kara for his excellent review.
Jan pointed out that we probably have an issue with the way hole punch
interacts with the fsync/msync code. This is the item that I'll work on
next, but I wanted to send this series out now as I think it will be
independent of the hole punch fixes.
This set applies cleanly on top of v8 of my "DAX fsync/msync support" set,
which is in -mm and -next. That set has not yet been merged for v4.5
which is why the my work tree is still based on -next:
https://git.kernel.org/cgit/linux/kernel/git/zwisler/linux.git/log/?h=fsy...
[1]: https://lists.01.org/pipermail/linux-nvdimm/2016-January/003952.html
Ross Zwisler (5):
dax: never rely on bh.b_dev being set by get_block()
dax: clear TOWRITE flag after flush is complete
dax: improve documentation for fsync/msync
dax: fix PMD handling for fsync/msync
dax: fix clearing of holes in __dax_pmd_fault()
fs/dax.c | 110 +++++++++++++++++++++++++++++++++++++++++++++++++--------------
1 file changed, 86 insertions(+), 24 deletions(-)
--
2.5.0
4 years, 9 months
