Re: [PATCH v7 5/7] libnvdimm: advertise 'call_dsm' support
On Wed, Mar 16, 2016 at 01:47:43PM -0700, Dan Williams wrote:
On Wed, Mar 16, 2016 at 1:21 PM, Jerry Hoemann
<jerry.hoemann(a)hpe.com> wrote:
> On Tue, Mar 15, 2016 at 03:08:14PM -0700, Dan Williams wrote:
[..]
> 3. sysfs extensions
>
> I had planned to do some type of extension for sysfs for passthru
> after getting basic features agreed upon. But, i hadn't thought
> it through deeply. As for:
>
> /sys/bus/nd/devices/nmem0/nfit/dsm_mask
> /sys/bus/nd/devices/nmem0/nfit/family
>
> Don't we want:
>
> /sys/bus/nd/devices/nmem0/dsm_mask
> /sys/bus/nd/devices/nmem0/family
>
> As the mask/family is associated with the dimm.
Hmm, I think more like this:
/sys/bus/nd/devices/nmem0/nfit/dsm_mask
/sys/bus/nd/devices/nmem0/family
The mask is associated with the dimm, but it is ACPI specific.
However, you're right that the family id is truly generic and should
be at the dimm level because the family type could span across
non-ACPI architectures.
We could abstract it to "cmd_mask" and put it off nmem0 like
family. Same reasoning should apply. Just something to think
about.
--
-----------------------------------------------------------------------------
Jerry Hoemann Software Engineer Hewlett Packard Enterprise
-----------------------------------------------------------------------------