On Fri, Jul 29, 2016 at 3:02 PM, Ross Zwisler
<ross.zwisler(a)linux.intel.com> wrote:
This commit:
commit 0d119368385a ("ndctl: reorganize file structure, use per sub-directory
makefiles")
reorganized the file structure & makefiles in ndctl, but broke builds that
used the --enable-destructive option. Here are some of the failure
messages:
../test/blk_namespaces.o: In function `test_blk_namespaces':
/root/project/ndctl/ndctl/../test/blk_namespaces.c:222: undefined reference to
`__ndctl_test_attempt'
/root/project/ndctl/ndctl/../test/blk_namespaces.c:250: undefined reference to
`__ndctl_test_skip'
The root cause of this build failure was that when --enable-destructive was
being set, test/core.c wasn't being compiled and included in the build,
hence the undefined references.
Fix the makefile to include test/core.c.
Signed-off-by: Ross Zwisler <ross.zwisler(a)linux.intel.com>
---
Hmm, are you perhaps trying to build with --enable-destructive without
--enable-test? I'll see if I can fix this up to warn about the
misconfiguration, the intent is that --enable-destructive is
incremental.