On Thu, Jun 21, 2018 at 10:40:33AM +0800, Eryu Guan wrote:
On Wed, Jun 20, 2018 at 04:51:47PM -0600, Ross Zwisler wrote:
> diff --git a/tests/generic/999 b/tests/generic/999
> new file mode 100755
> index 00000000..8f488cb5
> --- /dev/null
> +++ b/tests/generic/999
> @@ -0,0 +1,50 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2018 Intel Corporation. All Rights Reserved.
> +# FS QA Test generic/999
> +# This is a regression test for kernel patch:
> +# ext4: handle layout changes to pinned DAX mapping
> +# created by Ross Zwisler <ross.zwisler(a)linux.intel.com>
> +seq=`basename $0`
> +echo "QA output created by $seq"
> +status=1 # failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> + cd /
> + rm -f $tmp.*
> +# get standard environment, filters and checks
> +. ./common/rc
> +. ./common/filter
> +# remove previous $seqres.full before test
> +rm -f $seqres.full
> +# Modify as appropriate.
> +_supported_fs generic
> +_supported_os Linux
> +_require_test_program "t_mmap_collision"
I don't think I need these because I don't actually require this functionality
from xfs_io. I did try and use xfs_io for this test, but the way the
threading needs to work I ended up having to write my own C program. So,
even if xfs_io happens to be old and without fpunch, for example, as long as
fallocate can use FALLC_FL_PUNCH_HOLE I think the test should do the right
> diff --git a/tests/generic/group b/tests/generic/group
> index 83a6fdab..793f71ed 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -501,3 +501,4 @@
> 496 auto quick swap
> 497 auto quick swap collapse
> 498 auto quick log
> +999 auto quick dax
Also need "punch collapse zero" groups.
I'm assuming I should still add my test to these 3 groups, even though I'm not
getting this functionality via xfs_io?
Thank you for the review, I'll address the rest of your comments in v2.