Re: [PATCH v1] libnvdimm: Replace guid_copy() with import_guid() where it makes sense
On Wed, Apr 22, 2020 at 04:05:39PM +0300, Andy Shevchenko wrote:
There is a specific API to treat raw data as GUID, i.e.
import_guid().
Use it instead of guid_copy() with explicit casting.
Signed-off-by: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com>
Reviewed-by: Ira Weiny <ira.weiny(a)intel.com>
> ---
> drivers/acpi/nfit/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index fa4500f9cfd13..7c138a4edc03e 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -2293,7 +2293,7 @@ static int acpi_nfit_init_interleave_set(struct acpi_nfit_desc
*acpi_desc,
> nd_set = devm_kzalloc(dev, sizeof(*nd_set), GFP_KERNEL);
> if (!nd_set)
> return -ENOMEM;
> - guid_copy(&nd_set->type_guid, (guid_t *) spa->range_guid);
> + import_guid(&nd_set->type_guid, spa->range_guid);
>
> info = devm_kzalloc(dev, sizeof_nfit_set_info(nr), GFP_KERNEL);
> if (!info)
> --
> 2.26.1
>