Re: [PATCH v2 0/3] libnvdimm/security: Enumerate the frozen state and other cleanups

Changes since v1 [1]: - Cleanup patch1, simplify flags return in the overwrite case and consolidate frozen-state cases (Jeff) - Clarify the motivation for patch2 (Jeff) - Collect Dave's Reviewed-by

[1]: https://lists.01.org/pipermail/linux-nvdimm/2019-August/023133.html --- Jeff reported a scenario where ndctl was failing to unlock DIMMs [2]. Through the course of debug it was discovered that the security interface on the DIMMs was in the 'frozen' state disallowing unlock, or any security operation. Unfortunately the kernel only showed that the DIMMs were 'locked', not 'locked' and 'frozen'. Introduce a new sysfs 'frozen' attribute so that ndctl can reflect the "security-operations-allowed" state independently of the lock status. Then, followup with cleanups related to replacing a security-state-enum with a set of flags. [2]: https://lists.01.org/pipermail/linux-nvdimm/2019-August/022856.html --- Dan Williams (3): libnvdimm/security: Introduce a 'frozen' attribute libnvdimm/security: Tighten scope of nvdimm->busy vs security operations libnvdimm/security: Consolidate 'security' operations drivers/acpi/nfit/intel.c | 59 ++++++----- drivers/nvdimm/bus.c | 2 drivers/nvdimm/dimm_devs.c | 134 ++++++-------------------- drivers/nvdimm/nd-core.h | 51 ++++------ drivers/nvdimm/security.c | 199 +++++++++++++++++++++++++------------- include/linux/libnvdimm.h | 9 +- tools/testing/nvdimm/dimm_devs.c | 19 +--- 7 files changed, 226 insertions(+), 247 deletions(-)