Re: [PATCH 7/9] drivers/base: fix empty-body warnings in devcoredump.c
On Sat, Apr 18, 2020 at 11:41:09AM -0700, Randy Dunlap wrote:
@@ -294,11 +295,11 @@ void dev_coredumpm(struct device *dev, s
if (sysfs_create_link(&devcd->devcd_dev.kobj, &dev->kobj,
"failing_device"))
- /* nothing - symlink will be missing */;
+ do_empty(); /* nothing - symlink will be missing */
if (sysfs_create_link(&dev->kobj, &devcd->devcd_dev.kobj,
"devcoredump"))
- /* nothing - symlink will be missing */;
+ do_empty(); /* nothing - symlink will be missing */
INIT_DELAYED_WORK(&devcd->del_wk, devcd_del);
schedule_delayed_work(&devcd->del_wk, DEVCD_TIMEOUT);
Could just remove the 'if's?
+ sysfs_create_link(&devcd->devcd_dev.kobj, &dev->kobj,
+ "failing_device");