Re: [PATCH v4] ndctl: add clear error support for ndctl

On 05/01/2017 05:16 PM, Kani, Toshimitsu wrote: > On Mon, 2017-05-01 at 16:33 -0700, Dave Jiang wrote: >  : > > +EXAMPLES > > +-------- > > + > > +Clear poison (bad blocks) for the provided device > > +[verse] > > +ndctl clear-error -f /dev/dax0.0 -s 0 -l 8 > > + > > +Clear poison (bad blocks) at block offset 0 for 8 blocks on > > device > > /dev/dax0.0 > > + > > +OPTIONS > > +------- > > +-f:: > > +--file:: > > +The device/file to be cleared of poison (bad blocks). > > + > > +-s:: > > +--start:: > > +The offset where the poison (bad block) starts for this > > device. > > +Typically this is acquired from the sysfs badblocks file. > > + > > +-l:: > > +--len:: > > +The number of badblocks to clear in size of 512 bytes > > increments. The > > +length must fit within the badblocks range. If the length > > exceeds the > > +badblock range or is 0, the command will fail. > > Actually, I am seeing '-l 0' works just like '-l 1'. Oh now I remembered that Vishal requested that no length does 1 block clear. Do you want me to correct documentation or behavior?