Re: [driver-core PATCH v9 1/9] driver core: Establish order of operations for device_add and device_del via bitflag

On Thu, Dec 13, 2018 at 1:45 AM Alexander Duyck <alexander.h.duyck(a)linux.intel.com&gt; wrote: > > Add an additional bit flag to the device struct named "dead". > > This additional flag provides a guarantee that when a device_del is > executed on a given interface an async worker will not attempt to attach > the driver following the earlier device_del call. Previously this > guarantee was not present and could result in the device_del call > attempting to remove a driver from an interface only to have the async > worker attempt to probe the driver later when it finally completes the > asynchronous probe call. > > One additional change added was that I pulled the check for dev->driver > out of the __device_attach_driver call and instead placed it in the > __device_attach_async_helper call. This was motivated by the fact that the > only other caller of this, __device_attach, had already taken the > device_lock() and checked for dev->driver. Instead of testing for this > twice in this path it makes more sense to just consolidate the dev->dead > and dev->driver checks together into one set of checks. > > Reviewed-by: Dan Williams <dan.j.williams(a)intel.com&gt; > Signed-off-by: Alexander Duyck <alexander.h.duyck(a)linux.intel.com&gt; Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki(a)intel.com&gt;