Re: [RFC v3] [PATCH 0/18] DAX page fault locking

On Tue 10-05-16 16:39:37, Ross Zwisler wrote: > On Tue, May 10, 2016 at 02:30:03PM -0600, Ross Zwisler wrote: > > On Tue, May 10, 2016 at 05:28:14PM +0200, Jan Kara wrote: > > > On Mon 09-05-16 11:38:28, Jan Kara wrote: > > > Somehow, I'm not able to reproduce the warnings... Anyway, I think I see > > > what's going on. Can you check whether the warning goes away when you > > > change the condition at the end of page_cache_tree_delete() to: > > > > > > if (!dax_mapping(mapping) && !workingset_node_pages(node) && > > > list_empty(&node->private_list)) { > > > > Yep, this took care of both of the issues that I reported. I'll restart my > > testing with this in my baseline, but as of this fix I don't have any more > > open testing issues. :) > > Well, looks like I spoke too soon. The two tests that were failing for me are > now passing, but I can still create what looks like a related failure using > XFS, DAX, and the two xfstests generic/231 and generic/232 run back-to-back. Hum, full xfstests run completes for me just fine. Can you reproduce the issue with the attached debug patch? Thanks!