On Thu, Mar 8, 2018 at 9:21 AM, Ross Zwisler
On Wed, Mar 07, 2018 at 12:48:28PM -0800, Dan Williams wrote:
> On Wed, Mar 7, 2018 at 12:42 PM, Verma, Vishal L
> <vishal.l.verma(a)intel.com> wrote:
> > On Wed, 2018-03-07 at 11:53 -0700, Ross Zwisler wrote:
> >> Add support to 'ndctl list' so that we can filter DIMMs, regions
> >> namespaces based on numa node.
> > Something for the future - perhaps we can add this same numa node based
> > filtering to all the operations on namespaces/regions/dimms.
> This does have the region filtering, and that should also
> automatically filter namespaces since we wouldn't even consider the
> namespaces on a region where the numa node doesn't match.
What other supports of operations were you thinking about? Like
ndctl disable-region --numa_node=0
or something? It doesn't look like we use other ndctl list type filters for
other operations like that today? This seems powerful if we were to implement
it, but easy to accidentally operate on namespaces/regions you didn't intend.
This is Linux, defer to giving users all the rope they want.
> > Does it make sense to accept an 'all' option for numa node? We're
> > using it for filtering, and 'all' == not supplying the option at all..
> Same could be said for all the other places we accept all, I think it
> should be "all or nothing" (heh heh heh), i.e. if we accept it as an
> option for dimms regions and namespaces, why not numa nodes?
On a somewhat related note, what do you guys think of an option like this:
ndctl list --all
Which would just give you a full dump of all the various bits of info, so it
would currently be equivalent to:
ndctl list --buses --dimms --health --device-dax --regions --namespaces
Providing you with a single short command to get as much info about a system
Sounds good to me... should also include --firmware in that list. I'd
probably call it --everything since "all" is already reserved as a
keyword for specific object types. I.e. "ndct list" by default is
"all" namespaces so I would expect "ndctl list --all" to also be all