Re: [ndctl PATCH 1/3] ndctl: simplify JSON print flag handling

On Fri, Jun 29, 2018 at 4:39 PM, Ross Zwisler <ross.zwisler(a)linux.intel.com&gt; wrote: > json_object_to_json_string_ext()'s second argument is a flags field > which > we always want to be JSON_C_TO_STRING_PRETTY. We were going to a > lot of > trouble for this, though. We had multiple variables set to be this > one > flag and util_display_json_array() took it as an argument, even > though it > never varied. > > Instead, just pass in the necessary flag when calling > json_object_to_json_string_ext(), removing the local variables and > the extra > argument to util_display_json_array(). I was thinking of one day supporting a flag other than JSON_C_TO_STRING_PRETTY and have it be controlled by the command line. However that never materialized, and we could always use an environment variable to change the json format flag.

So, Acked-by: Dan Williams <dan.j.williams(a)intel.com&gt;