10:04 p.m.
On Fri, Mar 11, 2016 at 1:16 PM, Jerry Hoemann <jerry.hoemann(a)hpe.com> wrote:
Add struct nd_cmd_pkg which serves as a warapper for
the data being passed via a pass thru to a NVDIMM DSM.
This wrapper specifies the extra information in a uniform
manner allowing the kenrel to call a DSM without knowing
specifics of the DSM.
Add dsm_call command to nvdimm_bus_cmd_name and nvdimm_cmd_name.
Signed-off-by: Jerry Hoemann <jerry.hoemann(a)hpe.com>
---
include/uapi/linux/ndctl.h | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux/ndctl.h
index 7cc28ab..459c6ba 100644
--- a/include/uapi/linux/ndctl.h
+++ b/include/uapi/linux/ndctl.h
@@ -125,6 +125,7 @@ enum {
ND_CMD_VENDOR_EFFECT_LOG_SIZE = 7,
ND_CMD_VENDOR_EFFECT_LOG = 8,
ND_CMD_VENDOR = 9,
+ ND_CMD_CALL_DSM = 10,
};
enum {
@@ -139,6 +140,7 @@ static inline const char *nvdimm_bus_cmd_name(unsigned cmd)
[ND_CMD_ARS_START] = "ars_start",
[ND_CMD_ARS_STATUS] = "ars_status",
[ND_CMD_CLEAR_ERROR] = "clear_error",
+ [ND_CMD_CALL_DSM] = "dsm_call",
};
if (cmd < ARRAY_SIZE(names) && names[cmd])
@@ -158,6 +160,7 @@ static inline const char *nvdimm_cmd_name(unsigned cmd)
[ND_CMD_VENDOR_EFFECT_LOG_SIZE] = "effect_size",
[ND_CMD_VENDOR_EFFECT_LOG] = "effect_log",
[ND_CMD_VENDOR] = "vendor",
+ [ND_CMD_CALL_DSM] = "dsm_call",
};
if (cmd < ARRAY_SIZE(names) && names[cmd])
@@ -224,4 +227,23 @@ enum ars_masks {
ARS_STATUS_MASK = 0x0000FFFF,
ARS_EXT_STATUS_SHIFT = 16,
};
+
+
+struct nd_cmd_pkg {
+ __u32 ncp_type;
I think 'family' is more clear, to signify the class of commands that
the 'command' parameter references. Also let's drop the ncp_ prefix,
it's non-idiomatic with the rest of the definitions in this file.
+ __u32 ncp_rev;
Why do we need a separate revision field? A 'revision' change
effectively selects a different 'family' of commands, so I don't think
we need to reflect that ACPI-specific aspect of the commands at this
level.
+ __u64 ncp_command;
+ __u32 ncp_size_in; /* size of input payload */
+ __u32 ncp_size_out; /* size of user buffer */
What's "user" in this context? How about "/* size of output payload
*/"
+ __u32 ncp_reserved2[9]; /* reserved must be
zero */
+ __u32 ncp_pot_size; /* potential output size */
It's not 'potential'' it's the 'actual' output size written by
the
kernel/firmware, right?
+ unsigned char ncp_payload[]; /* Contents of call
*/
+};
+
+#define NCP_TYPE_BUS 1
+#define NCP_TYPE_DIMM_INTEL1 2
+#define NCP_TYPE_DIMM_N_HPE1 3
+#define NCP_TYPE_DIMM_N_HPE2 4
s/NCP_TYPE_/ND_FAMILY_/
I think it would be helpful to put comments in the code here about
where these families are defined.