On Mon, 2019-04-01 at 06:20 +0000, qi.fuli(a)fujitsu.com wrote:
Thanks for your comment.
I think it might be misunderstood.
Current scenario is:
1. Check if "-c <file>" option is provided
a. if it is, make the <file> as config_file
b. if it is not, make default configuration file(/etc/ndctl/monitor.conf) as
2. Try to read options from config_file
a. if config_file cannot be opened, then check if "-c" option is provided
(1) if it is, stop starting monitor (user may make a wrong <file> in
(2) if it is not, finish read_config_file (default configuration
file(/etc/ndctl/monitor.conf) is missing)
b. if config_file can be opened successfully, merge the options from config_file with
It is consistent with the ideal scenario as you mentioned.
Looking at it in more detail, I see you're right.
I've applied the patch - thanks for the explanation.