On 01/03/18 10:44 AM, Bjorn Helgaas wrote:
I think these two statements are out of order, since the attributes
dereference pdev->p2pdma. And it looks like you set "error"
unnecessarily, since you return immediately looking at it.
Per the previous series, sysfs_create_group is must_check for some
reason. I had a printk there but you didn't think it was necessary. So
assigning it to error is the only way to squash the warning.