Re: [ndctl PATCH 3/5] ndctl/dimm: Add offset and size options to {read, write, zero}-labels

On Tue, 2019-03-05 at 17:34 -0800, Dan Williams wrote: > Allow for more precision in label utilities, i.e. stop operating over > the entire label area. > > Signed-off-by: Dan Williams <dan.j.williams(a)intel.com&gt; > --- > Documentation/ndctl/labels-options.txt | 9 ++++++ > ndctl/dimm.c | 45 ++++++++++++++++++++++++-------- > ndctl/lib/dimm.c | 36 +++++++++++++++++++++----- > ndctl/lib/libndctl.sym | 2 + > ndctl/lib/private.h | 3 -- > ndctl/libndctl.h | 4 +++ > util/util.h | 4 +++ > 7 files changed, 83 insertions(+), 20 deletions(-) > [..] > diff --git a/ndctl/lib/private.h b/ndctl/lib/private.h > index 5a17f0b63b80..1304017d5e3b 100644 > --- a/ndctl/lib/private.h > +++ b/ndctl/lib/private.h > @@ -241,9 +241,6 @@ struct ndctl_namespace { > * > * A command may only specify one of @source, or @iter.total_buf, not both. > */ > -enum { > - READ, WRITE, > -}; This fails to build as libndctl.c now needs to include util/util.h.. Stale version perhaps? (Patch 4 in the series also fails to apply cleanly)