Re: [PATCH 0/3] dynamic_hex_dump cleanup
On Fri, Apr 28, 2017 at 2:49 PM, Joe Perches <joe(a)perches.com> wrote:
On Fri, 2017-04-28 at 14:28 -0700, Dan Williams wrote:
> More than one driver has worked around the fact that
> print_hex_dump_debug() requires CONFIG_DYNAMIC_DEBUG=y to build.
No it doesn't. builds work fine. Output is restricted.
> Provide a dynamic_hex_dump() so that drivers that want the extra debugging to be
> turned off in the CONFIG_DYNAMIC_DEBUG=n can use dynamic_hex_dump()
> directly.
I think the concept is unnecessary
.
Just use print_hex_dump with KERN_DEBUG.
No, we don't want any possibility of output in the
CONFIG_DYNAMIC_DEBUG=n case. This is extra debug that only makes sense
in the CONFIG_DYNAMIC_DEBUG case.