Re: [PATCH] libnvdimm/e820: Fix build error without MEMORY_HOTPLUG

Hi YueHaibing, Thank you for the patch! Yet something to improve: [auto build test ERROR on linux-nvdimm/libnvdimm-for-next] [also build test ERROR on v5.9-rc2 next-20200826] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/YueHaibing/libnvdimm-e820-Fix-bu... base: https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git libnvdimm-for-next config: i386-randconfig-a004-20200826 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): 21 | static inline int phys_to_target_node(u64 start) | ^~~~~~~~~~~~~~~~~~~ In file included from include/linux/nodemask.h:96, from include/linux/sched.h:22, from include/linux/ratelimit.h:6, from include/linux/dev_printk.h:16, from include/linux/device.h:15, from include/linux/platform_device.h:13, from drivers/nvdimm/e820.c:6: include/linux/numa.h:38:19: note: previous definition of 'phys_to_target_node' was here 38 | static inline int phys_to_target_node(phys_addr_t addr) | ^~~~~~~~~~~~~~~~~~~ # https://github.com/0day-ci/linux/commit/4c003ae129dccea4445a55e9e2c61de59... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review YueHaibing/libnvdimm-e820-Fix-build-error-without-MEMORY_HOTPLUG/20200826-202043 git checkout 4c003ae129dccea4445a55e9e2c61de5922fbd37 vim +/phys_to_target_node +21 drivers/nvdimm/e820.c 19 20 #ifndef CONFIG_MEMORY_HOTPLUG 22 { 23 return 0; 24 } 25 #endif 26 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org