Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io
Dan Williams <dan.j.williams(a)intel.com> writes:
On Fri, Apr 15, 2016 at 11:24 AM, Jeff Moyer
<jmoyer(a)redhat.com> wrote:
>> Moreover, we're going to do the full badblocks lookup anyway when we
>> call ->direct_access(). If we had that information earlier we can
>> avoid this fallback dance.
>
> None of the proposed approaches looks clean to me. I'll go along with
> whatever you guys think is best. I am in favor of wrapping up all that
> duplicated code, though.
Christoph originally pushed for open coding this fallback decision
per-filesystem. I agree with you on the "none the above" options are
clean.
I don't recall him saying "open code". Rather, the sentiment was to
leave the fallback to the callers. That doesn't mean you can't wrap it
up in a convenience function.
Cheers,
Jeff