On Tue, 2019-03-26 at 23:29 +0000, Dexuan Cui wrote:
Here ndctl is checking if ND_CMD_SMART is supported in
dimm->cmd_mask. For all the non-NVDIMM_FAMILY_INTEL families,
the check is false, including the HPE1 and MSFT families.
So IMO we need this new dimm-ops to make "ndctl monitor" work
for Hyper-V. I think the other non-INTEL families can't work with
"ndctl monitor" either, but I don't have a hardward to test.
Ah ok makes sense - I think with that I don't have any other comments -
I'll queue the patches for the pending branch.
Thanks,
-Vishal