Re: [PATCH 2/4] memremap: remove the dev field in struct dev_pagemap
On Tue, Aug 20, 2019 at 6:27 AM Jason Gunthorpe <jgg(a)mellanox.com> wrote:
On Mon, Aug 19, 2019 at 06:44:02PM -0700, Dan Williams wrote:
> On Sun, Aug 18, 2019 at 2:12 AM Christoph Hellwig <hch(a)lst.de> wrote:
> >
> > The dev field in struct dev_pagemap is only used to print dev_name in
> > two places, which are at best nice to have. Just remove the field
> > and thus the name in those two messages.
> >
> > Signed-off-by: Christoph Hellwig <hch(a)lst.de>
> > Reviewed-by: Ira Weiny <ira.weiny(a)intel.com>
>
> Needs the below as well.
>
> /me goes to check if he ever merged the fix to make the unit test
> stuff get built by default with COMPILE_TEST [1]. Argh! Nope, didn't
> submit it for 5.3-rc1, sorry for the thrash.
>
> You can otherwise add:
>
> Reviewed-by: Dan Williams <dan.j.williams(a)intel.com>
>
> [1]:
https://lore.kernel.org/lkml/156097224232.1086847.9463861924683372741.stg...
Can you get this merged? Do you want it to go with this series?
Yeah, makes some sense to let you merge it so that you can get
kbuild-robot reports about any follow-on memremap_pages() work that
may trip up the build. Otherwise let me know and I'll get it queued
with the other v5.4 libnvdimm pending bits.