Re: [PATCH 04/16] libnvdimm: Move nd_numa_attribute_group to device_type
On Tue, Nov 12, 2019 at 1:23 AM Aneesh Kumar K.V
<aneesh.kumar(a)linux.ibm.com> wrote:
Dan Williams <dan.j.williams(a)intel.com> writes:
> A 'struct device_type' instance can carry default attributes for the
> device. Use this facility to remove the export of
> nd_numa_attribute_group and put the responsibility on the core rather
> than leaf implementations to define this attribute.
>
> Cc: Ira Weiny <ira.weiny(a)intel.com>
> Cc: Michael Ellerman <mpe(a)ellerman.id.au>
> Cc: "Oliver O'Halloran" <oohall(a)gmail.com>
> Cc: Vishal Verma <vishal.l.verma(a)intel.com>
> Cc: Aneesh Kumar K.V <aneesh.kumar(a)linux.ibm.com>
> Signed-off-by: Dan Williams <dan.j.williams(a)intel.com>
can we also expose target_node in a similar way? This allows application
to better understand the node locality of the SCM device.
It is already exported for device-dax instances. See
DEVICE_ATTR_RO(target_node) in drivers/dax/bus.c. I did not see a use
case for it to be exported for other nvdimm device types.