From: Verma, Vishal L [mailto:vishal.l.verma@intel.com]
Sent: Thursday, April 19, 2018 1:06 AM
To: Williams, Dan J <dan.j.williams(a)intel.com>; Qi, Fuli/斉 福利
<qi.fuli(a)jp.fujitsu.com>
Cc: linux-nvdimm(a)lists.01.org
Subject: Re: [PATCH v2] ndctl, filter: refacor util_<obj>_filter() to support
multiple
space-seperated arguments
On Wed, 2018-04-18 at 07:31 -0700, Dan Williams wrote:
> On Tue, Apr 17, 2018 at 11:32 PM, QI Fuli <qi.fuli(a)jp.fujitsu.com> wrote:
> > This patch refactors util_<obj>_filter to support multiple space-
> > seperated arguments. Currently, only one <object> can be filtered by
> > <object>'s name in util_<obj>_filter(). As a result, when users
want
> > to moniotr multiple dimms, they have to run multiple monitor
> > processes. This feature teachs the
> > util_dimm_filter() that the "ident" argument maybe a space-seperatd
> > string which includes multiple dimm_names. Therefore the monitor can
> > filter multiple dimms in one process.
> >
> > Signed-off-by: QI Fuli <qi.fuli(a)jp.fujitsu.com>
> > Signed-off-by: Dan Williams <dan.j.williams(a)intel.com>
I'll fix up the tags like so:
Based-on-a-patch-by: Dan Williams <dan.j.williams(a)intel.com>
Reviewed-by: Dan Williams <dan.j.williams(a)intel.com>
Signed-off-by: QI Fuli <qi.fuli(a)jp.fujitsu.com>
Thanks,
-Vishal
> >
> > Change log since v1:
> > - Removing OPT_STRING_LIST from parse-option
>
> Looks good:
>
> Reviewed-by: Dan Williams <dan.j.williams(a)intel.com>
Thank you very much.
- Qi