Re: [PATCH v6] ndctl: add option to list firmware information for a DIMM

Adding firmware output of firmware information when ndctl list -D -F is used. Components displayed are current firmware version, next firmware version, and if a powercycle is required (firmware updated). Signed-off-by: Dave Jiang <dave.jiang(a)intel.com&gt; Tested-by: Jeff Moyer <jmoyer(a)redhat.com&gt;

+struct json_object *util_dimm_firmware_to_json(struct ndctl_dimm *dimm, + unsigned long flags) +{ + struct json_object *jfirmware = json_object_new_object(); + struct json_object *jobj; + struct ndctl_cmd *cmd; + int rc; + uint64_t run, next; + bool reboot = false; + + if (!jfirmware) + return NULL; + + cmd = ndctl_dimm_cmd_new_fw_get_info(dimm); + if (!cmd) + goto err; + + rc = ndctl_cmd_submit(cmd); + if (rc || ndctl_cmd_fw_xlat_firmware_status(cmd) != FW_SUCCESS) { + int run_err = -1;

+ + jobj = util_json_object_hex(run_err, flags); + if (jobj) + json_object_object_add(jfirmware, "current_version", + jobj); + goto out; + } + + run = ndctl_cmd_fw_info_get_run_version(cmd); + if (run == ULLONG_MAX) { + int run_err = -1; + + jobj = util_json_object_hex(run_err, flags); + if (jobj) + json_object_object_add(jfirmware, "current_version", + jobj); + goto out; + } + + jobj = util_json_object_hex(run, flags); + if (jobj) + json_object_object_add(jfirmware, "current_version", jobj); + + next = ndctl_cmd_fw_info_get_next_version(cmd); + if (next == ULLONG_MAX) { + int next_err = -1; + + jobj = util_json_object_hex(next_err, flags); + if (jobj) + json_object_object_add(jfirmware, "next_version", + jobj); + goto out; + } + + if (next != 0) { + reboot = true; + jobj = util_json_object_hex(next, flags); + if (jobj) + json_object_object_add(jfirmware, + "next_version", jobj); + } + + if (reboot) { + jobj = json_object_new_boolean(reboot); + if (jobj) + json_object_object_add(jfirmware, + "need_powercycle", jobj); + }