On Tue, 2016-02-09 at 13:08 +0100, Ingo Molnar wrote:
* Borislav Petkov <bp(a)suse.de> wrote:
> On Tue, Feb 09, 2016 at 12:27:32PM +0100, Ingo Molnar wrote:
> > Btw., IIRC GAS is being silly about .L, i.e. there's a difference
> > between these
> > two variants:
> >
> > .Lerror_entry_from_usermode_swapgs:
> > .L_error_entry_from_usermode_swapgs:
> >
> > the latter would be easier to read, but does not result in a local
> > label last I
> > checked.
> >
> > Right?
>
> Seems to build ok here with "GNU assembler (GNU Binutils)
> 2.26.51.20151207".
> Perhaps some bug with older gas...?
Hm, indeed - I just tried it too.
This means that the (slightly) more readable .L_ prefix is preferred.
Thanks for the suggestions! I will update the patch accordingly.
-Toshi